Fail on ruby 1.9.3, jruby 1.6.8 --1.9

[dekellum]

json-schema 1.0.9 fails to validate on 1.9 rubies with:

NoMethodError: undefined method `each' for "#":String
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/validator.rb:92:in `validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/schema.rb:38:in `validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/attributes/additionalproperties.rb:18:in `block in validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/attributes/additionalproperties.rb:15:in `each'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/attributes/additionalproperties.rb:15:in `validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/validator.rb:94:in `block in validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/validator.rb:92:in `each'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/validator.rb:92:in `validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/schema.rb:38:in `validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/attributes/properties.rb:15:in `block in validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/attributes/properties.rb:6:in `each'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/attributes/properties.rb:6:in `validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/validator.rb:94:in `block in validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/validator.rb:92:in `each'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/validator.rb:92:in `validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/schema.rb:38:in `validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/validator.rb:174:in `validate'
    ruby/1.9.1/gems/json-schema-1.0.9/lib/json-schema/validator.rb:309:in `validate!'

[hoxworth]

Is this still an issue? I haven't been able to reproduce on the current master release on either JRuby or MRI 1.9.3

[laser]

Hey @hoxworth

Following an example from the docs, the following works:

schema = {
  type: 'object',
  "required" => ["a"],
  properties: {
    a: {type: "integer", default: 42},
    b: {type: "integer"}
  }
}

data = {
  b: 5
}

is_valid = JSON::Validator.validate(schema, data)

but when the "required" key is changed to use the new Hash syntax, the following fails (with a NoMethodError):

schema = {
  type: 'object',
  required: ["a"], # <----- new Hash syntax
  properties: {
    a: {type: "integer", default: 42},
    b: {type: "integer"}
  }
}

data = {
  b: 5
}

is_valid = JSON::Validator.validate(schema, data)

The specific error is:

Failure/Error: is_valid = JSON::Validator.validate(schema, data)
     NoMethodError:
       undefined method `each' for nil:NilClass

Ruby info:

ruby 1.9.3p429 (2013-05-15 revision 40747) [x86_64-darwin12.3.0]

Gem info:

json-schema (2.1.1)

[hoxworth]

Thanks @laser , will start taking a look at this soon.

[hoxworth]

Yeah... the library was written to assume string keys in the schema. I'll add a todo to add indifferent access; this affects other keywords, like allOf, noneOf, etc.

[hoxworth]

Just push version 2.1.2 that should fix this issue, as well as other symbol -> string issues.

Thanks.