bareos::director tries to collect all exported File resources

[selverob]

Here:

https://github.com/Project0/puppet-bareos/blob/979d73480325bdf68d496b4913eedc7c9bfd64f0/manifests/director.pp#L63

bareos::director class tries to collect all the exported file resources in the catalog. When we try to apply it, Puppet attempts to create unrelated files (for example Prometheus collector config files) which should be collected on another server. This makes the Puppet run fail.

The file collection should be scoped by tag. We also tried fixing it by just removing the File <| |> -> statement and it doesn't seem to have broken anything.

[project0]

interesting, actually it should not affect other modules. The File resource collector is required to ensure consistent behaviour after file changes, so it does not restart the bareos services while its still changing its config files (which can happen).
Anyway, adding a tag to the files should be doable.

[selverob]

Well, the collector doesn't break anything in Bareos, it's our other modules that are affected. Our situation is like this:

• We use Prometheus node_exporter to get server metrics. To configure it, we need to run a Docker container on the server bareos director is on and we need to add some configuration files to the Prometheus server. We achieve that by exporting a file resource (@@file {'...), which we tag with tag => 'prometheus'
• On the same server, we add ::bareos::profile::director class.
• Since File <| |> resource collector in bareos::director doesn't filter the collected files by anything, it tries to create the Prometheus config files which were exported (and were supposed to be created on a completely different server). That obviously fails, because there is no directory structure for those configs on the machine used for bareos director.

[project0]

should be fixed with #35