Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to voxpupuli #183

Closed
fpletz opened this issue May 3, 2016 · 35 comments
Closed

Migrate to voxpupuli #183

fpletz opened this issue May 3, 2016 · 35 comments
Labels
needs-work not ready to merge just yet

Comments

@fpletz
Copy link
Contributor

fpletz commented May 3, 2016

The original maintainers of puppet-php are not developing it actively anymore because they have moved on from Puppet. 🐼

Here is your proposed plan of action:

  • Find new maintainers and give them push rights to the repository and later also the Puppet Forge
  • If we find passionate and active maintainers we will transfer the ownership of puppet-php to them officially

Please comment on this issue if you want to help out. You should at the very least be an active user and ideally have already contributed to the project.

Thanks! ❤️

@fpletz fpletz added the needs-help Extra attention is needed label May 3, 2016
@fpletz fpletz mentioned this issue May 3, 2016
@mmoll
Copy link
Contributor

mmoll commented May 3, 2016

I'd like to nominate @igalic for push access as a first measure.

@igalic
Copy link
Contributor

igalic commented May 7, 2016

oh dear… i mean… i am honoured and would like to thank you.
seeing as this module is _puppet approved_ — would you consider moving it to @voxpupuli?
if so, i can make invite either of you to @voxpupuli/module-admin

@jkroepke
Copy link
Contributor

It still a problem here?
Looks like the project is still active.

@mmoll
Copy link
Contributor

mmoll commented Jun 19, 2016

It still a problem here?

@jkroepke Yes, it is.

Looks like the project is still active.

I try to be a good Janitor. However, I use this module myself only in a very limited scope in an "unusual" setup and don't have too much time to really test it and its PRs as I would normally do. Also, the lacking spec test coverage is making big refactorings hard. My main goal for now would be to get PHP 5.6/7.0 version selection to a really woking state for all supported OSes and then release a 4.0.0.

@jkroepke
Copy link
Contributor

My main goal for now would be to get PHP 5.6/7.0

You should be open a epic ticket like owncloud/core#21237. User like me can grab small tasks from it and send and pr to you.

@mmoll
Copy link
Contributor

mmoll commented Jun 19, 2016

You should be open a epic ticket

We do have a 4.0.0 milestone - and, yes, I (or anybody else) could open new issues for that to break it down a little bit and I might do that, as soon as time permits. However, this does not solve the real problem of getting more people involved with the environments and skillsets needed.

@mmoll
Copy link
Contributor

mmoll commented Jul 3, 2016

@jkroepke BTW, we do have a lot of new issues for tracking now ;)

@rendhalver
Copy link

It looks like you guys are pretty swamped with the backlog of issues.
I would also recommend moving the module under the @voxpulli namespace too even more so considering it's Puppet Approved.

@mmoll
Copy link
Contributor

mmoll commented Jul 6, 2016

@rendhalver I opened a lot of issues, to somehow organize the situation. From what I get the state of things improved over the last few weeks and is pretty good on Debian/Ubuntu and SLES now. Other platforms lack testing and implementation of the 5.x/7.0 version switch (which might not be applicable for some, I know it would be doable for FreeBSD). Other module vendors (including Puppet Labs breaking FreeBSD in my experience!) would just release a 4.0 as-is and wait for issues/PRs come in. I also do see that as a viable option, if no further movement happens in the next few weeks.

Regarding voxpupuli, personally I don't think that would be the right place for a PHP module, but would see moving it to there as a very last resort to keep things up. However, at the same time I can't imagine more contributors will get attracted there, so the real problem of finding people that are willing to pour in time to develop this module further would also not get solved.

@rendhalver
Copy link

Ah that explains it.
I am testing this out for a new website deployment and the current release on puppet forge doesn't looks like it will do what I need it to.
I have noticed a lot of useful changes since the last release that will help with this project. Nice work.
You could push out a 4.0.0-rc1 release in preparation for the 4.0.0 release so it could get some extra testing.
If that will happen before the end of the week I am happy to track master to get that tested in my environment and let you know if I find any bugs.

@rendhalver
Copy link

Just letting you know I am using the master branch for this in my project.
I haven;t run into any issues yet.

@mmoll
Copy link
Contributor

mmoll commented Jul 7, 2016

Good to hear, thanks! I guess unlike on rubygems it won't be possible on the forge to mark a release as RC/beta so it doesn't get used by default?

@rendhalver
Copy link

I think the puppet module tool is setup to prefer stable over rc and beta versions.
This ancient bug would suggest it does: https://projects.puppetlabs.com/issues/17824

I use puppet-blacksmith and travis-ci do a puppet-forge release when I add tag.
If you want a hand setting it up let me know.

@mmoll
Copy link
Contributor

mmoll commented Jul 8, 2016

This looks good, I'll try to get out a 4.0.0-beta1 out of the door next week. I'm already using blacksmith over at @theforeman for its modules and quite 💚 it.

@rendhalver
Copy link

Lovely!
Drop a note here when you get that release out and I will start tracking it.

@mmoll
Copy link
Contributor

mmoll commented Jul 12, 2016

done :bowtie:

@rendhalver
Copy link

Awesome. I will switch to that tomorrow.

@davividal
Copy link

I would happily help with whatever I can.

@mmoll
Copy link
Contributor

mmoll commented Jul 29, 2016

@davividal If you can tackle any of the open issues, opening PRs would be much appreciated. Also reviewing incoming PRs of other people and even opening new issues to pinpoint problems we need to solve for a 4.0.0 release are bringing value.

@igalic
Copy link
Contributor

igalic commented Aug 5, 2016

@mmoll — it seems that this issue has been hijacked to discuss … something else :D
perhaps it's time to close it?
it seems to me that @mayflower is doing just a fine job of maintaining the module (again?)

@mmoll
Copy link
Contributor

mmoll commented Aug 5, 2016

tbh, I'm still looking for help and there are still plenty of open issues to be solved for 4.0.0

@khdevel
Copy link

khdevel commented Sep 2, 2016

Hello,

What is the current status of the "new puppet-php maintainers"? Is the code in a "freeze state" or under development?

Thank you!

@mmoll
Copy link
Contributor

mmoll commented Sep 2, 2016

@khdevel I can only point to my statement above

@igalic
Copy link
Contributor

igalic commented Sep 3, 2016

@mmoll o/~ hi

@mmoll
Copy link
Contributor

mmoll commented Sep 9, 2016

@igalic So, we'd like to give this to @voxpupuli as there were no new potential maintainers coming up here. I don't have the full control of this repo here, but other people in @mayflower have, what would be the process to transfer this repo?

@daenney
Copy link
Member

daenney commented Sep 10, 2016

That's documented here: https://voxpupuli.org/docs/#migrating-a-module-to-voxpupuli 😄.

@mmoll
Copy link
Contributor

mmoll commented Sep 11, 2016

@fadenb @fpletz (or anybody else), could you please coordinate?

@fadenb
Copy link
Contributor

fadenb commented Sep 11, 2016

  • Ask one of the Administrators to add you to the modules/admin team.
  • At that point you can transfer your own repository
  • If migrating a module from puppetlabs, re-enable github issues.
  • Verify that all webhooks except travis are disabled.
  • Update the README.md with a description of the deprecation and a link to the new module location.
  • Release a 999.999.999 version of the original module to the forge, so users and tools knows to stop using it.
  • Release a copy of your module to the ‘puppet’ forge account.
  • Add the module to our modulesync setup
  • Add the module to our plumbing repository(handles travis secrets)
  • Ask one of the Admins to add the module to the collaborators Team on github.

First steps are done. Will try to complete the rest tomorrow.

@robinbowes
Copy link

Did this get migrated yet? I'm currently stuck on:

Error: Could not install 'mayflower-php' (v999.999.999)
  No releases matching '999.999.999' are available from https://forgeapi.puppetlabs.com

@jk2l
Copy link
Contributor

jk2l commented Oct 4, 2016

no don't think so. it seem they are still fixing the test case. if you don't need newest OS support. You can consider use old version like 3.4.2

or you can just directly use voxpupuli/puppet-php with git

@robinbowes
Copy link

Cheers - I'll pin to 3.4.2 for now

@mmoll
Copy link
Contributor

mmoll commented Nov 20, 2016

close this please.

@rnelson0 rnelson0 reopened this Nov 20, 2016
@rnelson0
Copy link
Member

It looks like this isn't published to the forge in the puppet namespace yet and should remain open until that is complete.

@mmoll
Copy link
Contributor

mmoll commented Nov 20, 2016

oh, ok

@juniorsysadmin juniorsysadmin added needs-work not ready to merge just yet and removed needs-help Extra attention is needed labels Dec 25, 2016
@juniorsysadmin juniorsysadmin changed the title Find new maintainers Migrate to voxpupuli Dec 25, 2016
@daenney
Copy link
Member

daenney commented Jun 3, 2017

@rnelson0 It is published now. Could we close this and poke someone from Puppet Labs to tag puppet/php as the approved module instead of this version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work not ready to merge just yet
Projects
None yet
Development

No branches or pull requests