Remove hard dependency from apt-transport-https

[jkroepke]

Hi,

puppet-php/manifests/repo/debian.pp

Line 95 in 3e00b52

Package['apt-transport-https', 'lsb-release', 'ca-certificates']

since apt-transport-https is in Ubuntu 18.04/Debian 10 just a transitional package it isn't mandatory anymore, the apt-transport-https dependency should be conditional.

Since puppetlabs-apt handle this correctly you should just consume it instead manage it self.

See:

• https://packages.ubuntu.com/bionic/apt-transport-https
• https://packages.debian.org/buster/apt-transport-https

[bastelfreak]

Hi @jkroepke, thanks for raising this issue. Can you provide PR for it?

[jkroepke]

@bastelfreak I would like to do but unlike other voxpupuli repositories the process / responsiveness of PR here are way too slow for my taste. Sorry.

[hostingnuggets]

Am I getting hit by this?

Error: Failed to apply catalog: Found 1 dependency cycle:
(Package[apt-transport-https] => Apt::Source[source_php_71] => Package[apt-transport-https])
Try the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz

[juniorsysadmin]

Related to #285

[TuningYourCode]

Already resolved by #494
This issue could be closed.