Rabbitmq_exchange resource produces errors

[matthewbarr]

root@puppet:/etc/puppet# puppet resource rabbitmq_exchange
Error: Could not run: Execution of '/usr/local/bin/rabbitmqadmin list exchanges' returned 1: Traceback (most recent call last):
File "/usr/local/bin/rabbitmqadmin", line 939, in
main()
File "/usr/local/bin/rabbitmqadmin", line 370, in main
(options, args) = make_configuration()
File "/usr/local/bin/rabbitmqadmin", line 319, in make_configuration
config_file = default_config()
File "/usr/local/bin/rabbitmqadmin", line 310, in default_config
return home + os.sep + ".rabbitmqadmin.conf"
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

This is with 3.1.0, and a 3.3.2 of puppet. It's also produced by the mcollective module, when it tries to add exchanges.

I suspect that it's having a problem parsing the output of the command. Rabbit version 3.2.1

I'm going to go looking at the code now.

[matthewbarr]

What's odd is that it looks like that's a python error, not a ruby one. I can run the commands that the mcollective module is trying without an issue on the command line without issue. Only when it's run by puppet is it an issue.

(This is a vagrant install of mcollective, for testing and debugging this problem. it uses the defaults :)

Error: Could not prefetch rabbitmq_exchange provider 'rabbitmqadmin': Execution of '/usr/local/bin/rabbitmqadmin list exchanges' returned 1: Traceback (most recent call last):
File "/usr/local/bin/rabbitmqadmin", line 939, in
main()
File "/usr/local/bin/rabbitmqadmin", line 370, in main
(options, args) = make_configuration()
File "/usr/local/bin/rabbitmqadmin", line 319, in make_configuration
config_file = default_config()
File "/usr/local/bin/rabbitmqadmin", line 310, in default_config
return home + os.sep + ".rabbitmqadmin.conf"
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

Error: Execution of '/usr/local/bin/rabbitmqadmin declare exchange --vhost=/mcollective --user=admin --password=secret name=mcollective_broadcast type=topic' returned 1: Traceback (most recent call last):
File "/usr/local/bin/rabbitmqadmin", line 939, in
main()
File "/usr/local/bin/rabbitmqadmin", line 370, in main
(options, args) = make_configuration()
File "/usr/local/bin/rabbitmqadmin", line 319, in make_configuration
config_file = default_config()
File "/usr/local/bin/rabbitmqadmin", line 310, in default_config
return home + os.sep + ".rabbitmqadmin.conf"
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

[matthewbarr]

Found the issue: RabbitMQ 3.2.0 broke the behavior of the provider. The command doesn't work when run via puppet.

Using the rabbitmqadmin from 3.1.5, - https://raw.github.com/rabbitmq/rabbitmq-management/rabbitmq_v3_1_5/bin/rabbitmqadmin - the provider works just perfectly.

I've opened a bug on their side, since this shouldn't break,
rabbitmq/rabbitmq-management#10

Would it be easier to just the API for this? vs getting rabbitmqadmin?

[maxpwil]

This error appears because the puppet user has no bash configuration by default. (keyword: /etc/passwd)
Just as quick fix proposal you can do something like this:

define components::rabbitmq::exchange (
  $vhost    = '',
  $type     = '',
  $user     = '',
  $password = '',
) {

  exec { "declare exchange ${name}":
    command     => "/usr/local/bin/rabbitmqadmin declare exchange --vhost=${vhost} --user=${user} --password=${password} name=${name} type=${type}",
    environment => 'HOME=/var/lib/puppet:/bin/bash',
    user        => 'root'
  }
}

[matthewbarr]

Thanks- i'd love to use that, but... the call is actually by the puppetlabs-mcollective module, and i'd prefer to avoid patching that.

For now, i'm just putting the "right" version of the admin tool into the correct place, so the code doesn't try to download it. That way, the type call actually works.

[matthewbarr]

Looks like it was resolved in RMQ 3.2.2, via my bug 25920.