New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sets): check for window to avoid SSR errors #511

Merged

antfu merged 1 commit into vuejs:master from TheAlexLichter:patch-1

Sep 12, 2020

Contributor

TheAlexLichter commented Sep 12, 2020 •

edited

Loading

Hey 👋🏻

The new version unfortunately breaks when using the composition API on server-side because of a missing check for typeof window !== 'undefined'.

This PR should add the check and avoid SSR errors 😋


          fix(sets): check for window to avoid SSR errors

d48b084

antfu merged commit 9ea7230 into vuejs:master

TheAlexLichter deleted the patch-1 branch

September 12, 2020 07:09

Member

antfu commented Sep 12, 2020

Fix released in 1.0.0-beta.13, thanks for catching it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet