Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methon breaking changes in release and make this package vue2compatable #69

Closed
Mister-Hope opened this issue Aug 20, 2019 · 9 comments
Closed

Comments

@Mister-Hope
Copy link
Contributor

Mister-Hope commented Aug 20, 2019

It has been 3 days after I commented in #62.
In my option, there should fewer breaking change. We should not start a breaking change as long as we can solve it, not open as much changes as we can. For examaple the name and components options , will probably inherited from vue 2, while now this package force us to hack it.

I really you should consider it carefully. Some users like me couldn't afford hacking and rehacking again and again while releasing new version.

@posva
Copy link
Member

posva commented Aug 20, 2019

It has been 3 days after I commented in #62.

While I understand your frustration, this doesn't give you the right to open an issue with this tone and drop all your frustration on the author of the lib (which I am not, I haven't even pushed to this repo).

A more appropriate way would have been to list specific breaking changes so anyone can work on fixing them. We will gladly accept a new issue with a more appropriate tone and listing the breaking changes that shouldn't have happened

@posva posva closed this as completed Aug 20, 2019
@Mister-Hope
Copy link
Contributor Author

Mister-Hope commented Aug 20, 2019

I have methoned it in my issue:

The name and components options , will probably inherited from vue 2, while now this package force us to hack it.

while you don't see it.

That 's now where the problem is.

I do understand your work, while thoughn I was complaining about rewriting my files over and over again, but my point is stop making break changes which the RFC does not methoned. Just remain as the vue2 do, instead of changing into a new style or let us hack it. Among the people who are using this package , maybe some just wanna try vue3 style, but I think there are amount of people like me just want to be fimilar to vue3, and we are trying to prepare to move on to vue3. Just as its doc says(or used to say)(I didn't find the words just then): Just change the vue-function-api into vue. And we can move to vue3.

But while you upgraded it and I wrote with ts along with it, I rewrote all my components 4 times in order to clear the error I triggered after update. I WAS talking about vue2 compatable when the RFC and Evan You did not specific how to write in vue3.

@Mister-Hope
Copy link
Contributor Author

Mister-Hope commented Aug 20, 2019

I do think that you CAN understand what changes is non-RFC mentioned and non-vue2 compatable.
That is all my opinion.

If you want, I can start a new issue listing all the non-RFC mentioned and non-vue2 compatable changes, but I don't think that is nessary, and I also think that let the people who already swithed to roll back is not a good idea. So please just stop breaking any more now, if only it is nessary.

@liximomo
Copy link
Member

Sorry for that. We should warn the unstable status of vue-function-api. I think some beta releases would be necessary. We do consider our users.

@pangao66
Copy link

同样遇到这个问题,升级之后用ts发现 createComponent里面 只能写setup, 组件的其他属性,name,componets之类的都会报ts类型错误,这跟vue3目前公布的rfcs是违背的

@beeplin
Copy link

beeplin commented Aug 20, 2019

@pangao66 my workaround is to add // @ts-ignore before name.

Or please wait for bugfixes before updating to the current unstable version.

@Mister-Hope
Copy link
Contributor Author

Beta release will be fine. And I think the types file should be improved.

@donnysim
Copy link

But the v3 is only in rfc and this package is in early development, you using this package is already accepting that there will be breaking changes until it settles down. There's no reason to go ham just because you can't wait for it to become stable. While i would prefer it used <1 versioning until it's stable, it is what it is.

@Mister-Hope
Copy link
Contributor Author

Mister-Hope commented Aug 22, 2019

But the v3 is only in rfc and this package is in early development, you using this package is already accepting that there will be breaking changes until it settles down. There's no reason to go ham just because you can't wait for it to become stable. While i would prefer it used <1 versioning until it's stable, it is what it is.

Yes, I understand that, but i think breaking changes though a secend bit version should be list on the release panel. I did not get any warning for caution updating it. And any breaking change obeys vue2compatable should at least be discussed with others.

Besides, in my opinion, it's ok for the bugs in new version, as long as the author is active dealing with it, but I think breaking changes without being methoned is not good.

@Mister-Hope Mister-Hope changed the title NO MORE BREAKING CHANGE , NO MORE HACKING Methon breaking changes in release and make this package vue2compatable Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants