Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sfc): support using extends interface with defineProps() #4512

Merged
merged 3 commits into from
Oct 26, 2022
Merged

feat(sfc): support using extends interface with defineProps() #4512

merged 3 commits into from
Oct 26, 2022

Conversation

edison1105
Copy link
Member

close #4498

@edison1105 edison1105 marked this pull request as draft September 4, 2021 02:58
@edison1105 edison1105 marked this pull request as ready for review September 4, 2021 03:44
@oooplz
Copy link

oooplz commented Sep 10, 2021 •
edited
Loading

Why do the feat still no be merged to master branch.

My apologies for the ask. I am using vue-next to develop a lib. And i have one component should be creating some child components. So i thought the extends keyword was helpful for me.

But @yyx990803 has said that the workaround is to prefer writing props types in the same file instead of importing it.

Maybe the feat should be discussed.

@sambitevidev
Copy link

Is it going to be merged ?

@haoqunjiang haoqunjiang mentioned this pull request Apr 25, 2022
Closed
7 tasks
@AisonSu
Copy link

AisonSu commented May 31, 2022

Is it going to be merged ?

@brocjo
Copy link

brocjo commented Aug 26, 2022

Merge progress? Anyone have any clever workarounds? This would go a long way in helping abstract out some complicated bits of our component library...

@wvffle
Copy link

wvffle commented Sep 28, 2022

Over a year has passed since this PR got created :/ Merging it would help to really simplify our project :)

@yyx990803 yyx990803 merged commit 83f7e6f into vuejs:main Oct 26, 2022
@edison1105 edison1105 mentioned this pull request Nov 2, 2022
Closed
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
@edison1105
fix(compiler-sfc): support using extends interface with defineProps() (…
8bdecb4 
…vuejs#4512)

fix vuejs#4498
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
@edison1105 @zhangzhonghe
fix(compiler-sfc): support using extends interface with defineProps() (…
b11c406 
…vuejs#4512)

fix vuejs#4498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
scope: script-setup scope: sfc
Projects
Next Minor
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

defineProps 使用 extends 扩展 props 定义类型，导致 props 缺失 extends 的接口类型的属性
8 participants
@edison1105 @oooplz @sambitevidev @AisonSu @brocjo @wvffle @antfu @yyx990803