-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hmr/keep-alive): fix error in reload component (#7042) #7049
Conversation
efdba1e
to
b08e601
Compare
@yyx990803 你好,我发现这个 PR 与 #6809 重复了,并且你已经合并了 6809。但是我有一个疑问,就是 6809 的修复并不能通过我提供的测试,热更新的时候它没有调用旧组件的 我觉得被 |
@zhangzhonghe |
55b83f1
to
b8891ec
Compare
是的。但是修改后的新组件是会调用 |
有道理。 |
我是参考的这里的代码: core/packages/runtime-core/src/components/KeepAlive.ts Lines 426 to 435 in b8891ec
|
确实,保证 unmount 是必要的 |
fix #7042