Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue components don't get highlighted like React #1963

Closed
3 tasks done
max-programming opened this issue Jun 7, 2020 · 20 comments
Closed
3 tasks done

Vue components don't get highlighted like React #1963

max-programming opened this issue Jun 7, 2020 · 20 comments

Comments

@max-programming
Copy link

max-programming commented Jun 7, 2020

  • I have searched through existing issues
  • I have read through docs
  • I have read FAQ

Info

  • Platform: Windows
  • Vetur version: 0.24.0
  • VS Code version: 1.45.1

Problem

I love using Vetur. It is very fast and great. But when I do a React project, and in the highlighting, I saw that the components had a different colour (That is by VS Code) than the normal tags:

image

I noticed that Vue files did not have that thing:

image

Reproducible Case

It would be nice if the Vue components also have different colour highlighting

@max-programming
Copy link
Author

Will this feature be added? so should I close this issue

@ThatNUB
Copy link

ThatNUB commented Jun 29, 2020

Would be great to have it!

@amrbashir
Copy link

@max-programming don't close it, otherwise they will forget about it. We have to be patient and let them do their work.

@max-programming
Copy link
Author

max-programming commented Jun 29, 2020

okay. Thanks to support! I think they are working on it.

@octref
Copy link
Member

octref commented Aug 4, 2020

image

image

@octref octref closed this as completed in 811bb2a Aug 4, 2020
@max-programming
Copy link
Author

@octref I can't see it on mine. Do I have to change some settings?

@amrbashir
Copy link

amrbashir commented Aug 5, 2020

@max-programming works for me, It only works for <PascalCase> like <MyButton>.

@octref
Copy link
Member

octref commented Aug 5, 2020

It only works for <PascalCase>, which is consistent with React.

@max-programming
Copy link
Author

max-programming commented Aug 8, 2020

It only works for <PascalCase>, which is consistent with React.

This is what happens here:
I think there is some setting to change
image

I also reinstalled the extension but still doesn't work 😐

@octref
Copy link
Member

octref commented Aug 8, 2020

#2136

@max-programming
Copy link
Author

@octref Very happy to see the dedication and work towards this extension. Thanks a lot 😊
This is the other issue. It didn't get highlighted when expanded or if we write something between it
image

@octref
Copy link
Member

octref commented Aug 10, 2020

@max-programming Thanks for catching the cases 👍 #2146
I'd prefer opening new issues than appending to old issues though. It's easier to track.

@max-programming
Copy link
Author

This issue is finally solved. Sorry I checked it now

@jstiers
Copy link

jstiers commented Sep 8, 2020

What is the correct scope to change the color in a custom theme?

Thank you

@octref
Copy link
Member

octref commented Sep 10, 2020

support.class.component.html.

@Kolobok12309
Copy link

How disable this feature?)

@octref
Copy link
Member

octref commented Sep 21, 2020

editor.tokenColorCustomizations

@mathewcst
Copy link

Is there some setting that I should check? Or some specific theme? For me, it isn't working.

I'm using Vue 3 with Typescript, Community Material Theme and that's it. No highlights. But React highlights works.

@mathewcst
Copy link

mathewcst commented Nov 2, 2020

Found the issue (for me). I use WSL 2. When I open a project through WSL it doesn't get highlighted but when I open it through Windows it works perfectly.

image

Edit:
Microsoft's "Remove - WSL" extension was the problem. Removing it fixed the issue for me.

@octref
Copy link
Member

octref commented Nov 3, 2020

@mathewcst You might want to file an issue for them: https://github.com/Microsoft/vscode-remote-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants