Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript features not working in 0.11.8 #768

Closed
3 tasks done
KaelWD opened this issue Apr 17, 2018 · 14 comments
Closed
3 tasks done

Typescript features not working in 0.11.8 #768

KaelWD opened this issue Apr 17, 2018 · 14 comments

Comments

@KaelWD
Copy link

KaelWD commented Apr 17, 2018

  • I have searched through existing issues
  • I have read through docs
  • I have read FAQ

Info

  • Platform: Windows 10
  • Vetur version: 0.11.8 (from vsix)
  • VS Code version: 1.22.2

Updating tsc manually (#682 (comment)) with 0.11.7 works fine.

Problem

0.11.8:

No type information:
image
No hover hints:
image

0.11.7:

image
image

@HerringtonDarkholme
Copy link
Member

HerringtonDarkholme commented Apr 18, 2018

I cannot reproduce.

screen shot 2018-04-18 at 11 45 06 am

Can you provide a repro repository?

@KaelWD
Copy link
Author

KaelWD commented Apr 18, 2018

I can prepare one in a couple hours.

Does that still work for you if you use <script Lang="ts"> and export default Vue.extend({?

@HerringtonDarkholme
Copy link
Member

It still works. The problem probably is vetur crash. Otherwise in lang="ts" property at least will have any hover tip. And the completion list suggests no single vetur feature is working.

You can see vetur's log in output panel.

@KaelWD
Copy link
Author

KaelWD commented Apr 18, 2018

Nothing in the output panel, but I do see ERR Language client is not ready yet: Error: Language client is not ready yet at LanguageClient.sendNotification in devtools, twice for every keypress.

image

@KaelWD
Copy link
Author

KaelWD commented May 16, 2018

I'm still getting this with 0.12.1, even with all my other extensions disabled.

I get this error a few seconds after opening a .vue file, then the "language client is not ready" if I try to do anything afterwards:
image

Repro: https://github.com/KaelWD/vetur-ts-crash
2018-05-16_17-58-00

@octref
Copy link
Member

octref commented May 17, 2018

@KaelWD Sorry about that - It seems language server is not started properly for you.

What's the output from Output -> Vue Language Server?

image

@octref octref reopened this May 17, 2018
@octref
Copy link
Member

octref commented May 17, 2018

Also, would be helpful if you turn on "vetur.trace.server": "verbose" and show me the output from Vue Language Server.

@KaelWD
Copy link
Author

KaelWD commented May 18, 2018

Looks like it's working now for some reason, would the 0.12.3 changes have anything to do with that? I'll let you know if it starts breaking again.

@HerringtonDarkholme
Copy link
Member

HerringtonDarkholme commented May 18, 2018

We only removed chokidar.

The probable cause might be chokidar throw an exception that prevents language server from starting.

@KaelWD
Copy link
Author

KaelWD commented May 18, 2018

I guess that's fixed it then, I downgraded back to 0.12.1 and it started crashing again.

@octref Output shows vue initialized for the few seconds before the crash, but then the tab switches back to tasks. vetur.trace.server isn't recognised in 0.12.1.

@KaelWD KaelWD closed this as completed May 18, 2018
@KaelWD
Copy link
Author

KaelWD commented Jun 6, 2018

This seems to have regressed in 0.12.4

@KaelWD KaelWD reopened this Jun 6, 2018
@KaelWD
Copy link
Author

KaelWD commented Jun 6, 2018

I can't tell what the vue language server outputs with trace.server, the log disappears as soon as it crashes

image

image

@octref
Copy link
Member

octref commented Jun 6, 2018

Just to make sure the extension source is not corrupted - can you run the command Developer: Reinstall Extensions for Vetur?

@KaelWD
Copy link
Author

KaelWD commented Jun 7, 2018

Done, same problem still. Updating vscode to 1.24.0 with vetur 0.12.5 seems to be working again though.

@KaelWD KaelWD closed this as completed Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants