Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug when rewriting relative import in un-optimized node_modules #228

Closed
csr632 opened this issue May 22, 2020 · 1 comment
Closed

Bug when rewriting relative import in un-optimized node_modules #228

csr632 opened this issue May 22, 2020 · 1 comment
Labels
pending triage

Comments

@csr632
Copy link
Member

csr632 commented May 22, 2020 •
edited
Loading

Do NOT ignore this template or your issue will have a very high chance to be closed without comment.

Describe the bug

When dev server rewriting relative import inside un-optimized node_modules, the rewrited path is wrong and cause 404 when request the child modules.

This is the same issue with #204 but I didn't provide reproduction. So I open this issue.

Reproduction

Here is a minimal reproduce:
https://github.com/csr632/test-vite/tree/wrong-resolve

System Info

  • required vite version: 0.16.6
@csr632
Copy link
Member Author

csr632 commented May 22, 2020

I am working on this

@csr632 csr632 mentioned this issue May 22, 2020
Merged
yyx990803 pushed a commit that referenced this issue May 22, 2020
@csr632
fix: defaultRequestToFile should handle uncached node_modules request (…
7a3e822 
…#230)

fix #228
@csr632 csr632 mentioned this issue Jun 3, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
pending triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csr632