-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0.0-rc.11 peer dependency update is a breaking change #2114
Comments
Duplicate of #2109 |
RC version bumps are not patch changes. Also, all vue-cli projects, even created before RC11, come with |
Ahh yea you're right, should have said premajor. It started happening in AWS CodeBuild initially, so I tried a rebuild with a previous working build, and this one broke too. I took a look locally and did a clean checkout & npm install and I was able replicate. I believe npm will still install the latest premajor version with the ^. Should we peg this to an explicit version then? The project was created a few months ago with the vue cli, not sure which exact version (I think beta-5) so the ^ got carried over from that. I updated it for rc-10 and must have missed the npm warning. |
Once we release official 3.0 |
Word, thanks man! I was trying to align the code to the latest so we are ready for the stable 3.0 without much effort. Really appreciate all your work on vue & the cli by the way! We are using it for all our new projects, its just phenomenal all around. |
Version
3.0.0-rc.11
Node and OS info
all
Steps to reproduce
If your version is set to allow minor updates, for example: "@vue/cli-service": "^3.0.0-rc.10", then when you install, you get version 3.0.0-rc.11. The move of vue-template-compiler to the peer dependencies broke the build
npm WARN @vue/[email protected] requires a peer of vue-template-compiler@^2.0.0 but none is installed. You must install peer dependencies yourself.
What is expected?
Premajor changes shouldn't break build
What is actually happening?
Premajor change added a peer dependency that is breaking the build.
This is fixable by adding this to the deps or pegging the version explicitly.
Thanks!
The text was updated successfully, but these errors were encountered: