Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue submission form - preview should open links in a new tab #27

Closed
shawnheide opened this issue May 25, 2018 · 1 comment
Closed

Comments

@shawnheide
Copy link
Contributor

Steps to reproduce

Fill out the form on the issue helper (https://new-issue.vuejs.org/?repo=vuejs/vue). Click on the Preview button. Click on the link inside the preview window.

What is expected?

The link opens in a new tab.

What is actually happening?

The link opens in the current tab without submitting the issue. Going "back" in the browser results in an empty form.


Sadly, I discovered this the hard way after trying to submit my first issue.

@shawnheide
Copy link
Contributor Author

I looked into this and it looks like a limitation of the marked package. A workaround that was listed in a relevant issue on the marked repo suggested to simply extend the linkRenderer function. I'm creating a pull request with the suggested change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant