New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default props modified between tests suites #393

Closed

Alex-Sokolov opened this issue Jan 29, 2018 · 2 comments · Fixed by #613

Labels

help wanted intend to implement

Contributor

Alex-Sokolov commented Jan 29, 2018

Version

1.0.0-beta.11

Reproduction link

https://jsfiddle.net/bqtfqwpw/

Steps to reproduce

Tested component: https://jsfiddle.net/g7s289sh/
Tests suites: https://jsfiddle.net/bqtfqwpw/

Install vue/test-utils 1.0.0-beta.10
Run tests => All ok
Update vue/test-utils to 1.0.0-beta.11
Run tests => Test fails

What is expected?

Tests passed

What is actually happening?

Tests failed

Looks like vue/test-utils shared default props between test suites

Member

LinusBorg commented Jan 29, 2018

We should probably do a deep-clone here;
https://github.com/vuejs/vue-test-utils/blob/dev/src/lib/create-instance.js#L51

eddyerburgh added the intend to implement label

Member

eddyerburgh commented Feb 3, 2018

The problem with doing a deep clone is that we wouldn't be able to use stubs passed in propsData 🤔

eddyerburgh added the help wanted label

briwa mentioned this issue

fix: clone propsData to avoid mutation #613

Merged

eddyerburgh closed this as completed in #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment