chore(core): remove redundant async definition (#1264)

vuepress · Feb 19, 2023 · 6e63dba · 6e63dba
1 parent 37e7077
commit 6e63dba
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 16 deletions.
diff --git a/packages/core/src/page/createPage.ts b/packages/core/src/page/createPage.ts
@@ -39,7 +39,7 @@ export const createPage = async (
     links,
     sfcBlocks,
     title,
-  } = await renderPageContent({
+  } = renderPageContent({
     app,
     content,
     filePath,

diff --git a/packages/core/src/page/renderPageContent.ts b/packages/core/src/page/renderPageContent.ts
@@ -9,7 +9,7 @@ import type { App, PageFrontmatter, PageOptions } from '../types/index.js'
 /**
  * Render page content and extract related info
  */
-export const renderPageContent = async ({
+export const renderPageContent = ({
   app,
   content,
   filePath,
@@ -21,15 +21,15 @@ export const renderPageContent = async ({
   filePath: string | null
   filePathRelative: string | null
   options: PageOptions
-}): Promise<{
+}): {
   contentRendered: string
   deps: string[]
   frontmatter: PageFrontmatter
   headers: MarkdownHeader[]
   links: MarkdownLink[]
   sfcBlocks: MarkdownSfcBlocks
   title: string
-}> => {
+} => {
   const markdownEnv: MarkdownEnv = {
     base: app.options.base,
     filePath,

diff --git a/packages/core/tests/page/renderPageContent.spec.ts b/packages/core/tests/page/renderPageContent.spec.ts
@@ -11,8 +11,8 @@ const app = createBaseApp({
 app.markdown = createMarkdown()
 
 describe('core > page > renderPageContent', () => {
-  it('should render page content correctly', async () => {
-    const resolved = await renderPageContent({
+  it('should render page content correctly', () => {
+    const resolved = renderPageContent({
       app,
       content: `\
 foobar
@@ -64,8 +64,8 @@ const msg = 'msg'
   })
 
   describe('page title', () => {
-    it('should use title in frontmatter', async () => {
-      const resolved = await renderPageContent({
+    it('should use title in frontmatter', () => {
+      const resolved = renderPageContent({
         app,
         content: '# title in header',
         filePath: null,
@@ -80,8 +80,8 @@ const msg = 'msg'
       expect(resolved.title).toEqual('title in frontmatter')
     })
 
-    it('should use title in the first h1 header', async () => {
-      const resolved = await renderPageContent({
+    it('should use title in the first h1 header', () => {
+      const resolved = renderPageContent({
         app,
         content: '# title in header',
         filePath: null,
@@ -92,8 +92,8 @@ const msg = 'msg'
       expect(resolved.title).toEqual('title in header')
     })
 
-    it('should use empty title', async () => {
-      const resolved = await renderPageContent({
+    it('should use empty title', () => {
+      const resolved = renderPageContent({
         app,
         content: '',
         filePath: null,
@@ -106,8 +106,8 @@ const msg = 'msg'
   })
 
   describe('page frontmatter', () => {
-    it('should merge markdown frontmatter and options frontmatter', async () => {
-      const resolved = await renderPageContent({
+    it('should merge markdown frontmatter and options frontmatter', () => {
+      const resolved = renderPageContent({
         app,
         content: `\
 ---
@@ -129,8 +129,8 @@ title: title in markdown frontmatter
       })
     })
 
-    it('should use fields from markdown frontmatter first', async () => {
-      const resolved = await renderPageContent({
+    it('should use fields from markdown frontmatter first', () => {
+      const resolved = renderPageContent({
         app,
         content: `\
 ---