Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] Implement THORChain / MayaChain swap using normal send #935

Open
johnnyluo opened this issue Feb 8, 2025 · 0 comments
Open

[ADD] Implement THORChain / MayaChain swap using normal send #935

johnnyluo opened this issue Feb 8, 2025 · 0 comments
Labels
Desktop-Windows Issues related to vultisig windows application

Comments

@johnnyluo
Copy link
Collaborator

Based on the information from trust wallet team trustwallet/wallet-core#4209 (comment)

They will remove thorchain swap from wallet-core in the future, if they did that , we have to take some actions too

  1. We need to send the quote directly to THORChain / MayaChain
  2. construct a normal send transaction , with memo for swap

We are already doing that for a lot swap routes , but not for ERC20
@johnnyluo johnnyluo added the Desktop-Windows Issues related to vultisig windows application label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Desktop-Windows Issues related to vultisig windows application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnnyluo