Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listbox example has hardcoded empty aria-activedescendant value #429

Open
nschonni opened this issue Jul 20, 2017 · 8 comments
Open

Listbox example has hardcoded empty aria-activedescendant value #429

nschonni opened this issue Jul 20, 2017 · 8 comments
Assignees
Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation

Comments

@nschonni
Copy link
Contributor

https://github.com/w3c/aria-practices/blame/master/examples/listbox/listbox.html#L65
https://github.com/w3c/aria-practices/blame/master/examples/listbox/listbox.html#L129
I didn't dig into the JS, but I think the values might be set there. I'm guessing the should be removed to allow validation as the JS should set/clear them on its own.

@jnurthen
Copy link
Member

I have an open issue on ARIA to allow this
w3c/aria#501

@jnurthen
Copy link
Member

and a bug logged against aXe to allow it too
dequelabs/axe-core#179

@nschonni
Copy link
Contributor Author

👍 then it can always get filtered out of the Nu validator results in #421 if this is being worked on for the spec

@mcking65
Copy link
Contributor

Yes, we should add a filter to allow this.

@mcking65 mcking65 added the Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation label Jul 27, 2017
@mcking65 mcking65 added this to the 3Q17 Working Draft milestone Jul 27, 2017
@jnurthen jnurthen self-assigned this Sep 18, 2017
@mcking65
Copy link
Contributor

All instances of aria-activedescendant have been removed from the static HTML.

@spectranaut
Copy link
Contributor

I tried removing the filter from vnu-jar but we have another occurrence of "aria-activedescendant" being set explicitly to null. If I understand this comment on vnu-jar that they are not going to change this behavior, so we need to leave the filter in or to remove this occurrence. @mcking65 do you have a preference?

"file:/home/spectranaut/w3c/aria-practices/examples/listbox/listbox-rearrangeable.html":75.13-75.117: error: Bad value “” for attribute “aria-activedescendant” on element “ul”: An ID must not be the empty string.
"file:/home/spectranaut/w3c/aria-practices/examples/listbox/listbox-rearrangeable.html":135.13-141.42: error: Bad value “” for attribute “aria-activedescendant” on element “ul”: An ID must not be the empty string.

@spectranaut spectranaut reopened this Sep 3, 2020
@mcking65
Copy link
Contributor

mcking65 commented Sep 4, 2020

We fixed w3c/aria#501. So, I'm asking validator/validator#557 to be re-opened. In the meantime, I guess we keep the exception in .vnurc and track validator issue 557.

@carmacleod
Copy link
Contributor

Opened new validator/validator#1027 (as suggested in validator/validator#557).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Development

No branches or pull requests

5 participants