Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deactivated is not an errror #687

Closed
OR13 opened this issue Feb 20, 2021 · 3 comments
Closed

Deactivated is not an errror #687

OR13 opened this issue Feb 20, 2021 · 3 comments
Assignees
@peacekeeper
Labels
pr exists There is an open PR to address this issue

Comments

@OR13
Copy link
Contributor

OR13 commented Feb 20, 2021

The spec incorrectly lists "deactivated" as an error for resolution... however, deactivated
is a valid state for a DID Document, and resolving a deactivated DID MUST NOT produce an error.

Screen Shot 2021-02-20 at 12 59 00 PM
@OR13
Copy link
Contributor Author

OR13 commented Feb 20, 2021

@jricher @peacekeeper would either of you resolution experts care to fix this? :)

completing a valid DID Operation should not produce permanent errors during resolution.

@peacekeeper peacekeeper mentioned this issue Feb 22, 2021
Merged
@peacekeeper
Copy link
Contributor

Hmm we fixed this already in #581, but then it looks like it got unfixed in #601 :)

@peacekeeper peacekeeper added the pr exists There is an open PR to address this issue label Feb 22, 2021
@peacekeeper
Copy link
Contributor

Fixed by #691. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peacekeeper peacekeeper

Labels
pr exists There is an open PR to address this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@msporny @peacekeeper @OR13