webxr-1 2020-08-04 > 2020-08-27

[Manishearth]

In the issue title above add the document name followed by the date of this request, then the date of your proposed deadline for comments.

• name of spec to be reviewed: WebXR Device API Level 1

• URL of spec: https://immersive-web.github.io/webxr/

• What and when is your next expected transition? : We do not have a planned transition date yet, but we are hoping for CR soon.

• What has changed since any previous review?: I do not think there has been a previous review.

• Any information arising from a self-review?: Filed the checklist here. The spec largely does not deal in text and thus does not have most of these issues.

• Where and how to file issues arising? : https://github.com/immersive-web/webxr/issues/new

• Pointer to any explainer for the spec? : https://github.com/immersive-web/webxr/blob/master/explainer.md , and some secondary explainers for spatial tracking, input, and privacy and security

Other comments:

[himorin]

FPWD request is #74

[aphillips]

@Manishearth Could you be a little more specific about your expected due date? If you are "hoping for CR soon", is that several months? Or is it more immanent than that? Please leave time to resolve any comments that may arise.

[Manishearth]

@aphillips My hope is in a month. We have a couple small things to wrap up and then it's all about getting these reviews.

[aphillips]

@Manishearth Thanks. Based on that request I have set the due date to 27 August. In the future, please request horizontal review as far in advance as possible. It is better to have nothing to do just before CR than to have a mad scramble at the end 😉. Note that (COVID-19 aside) many people take the month of August off.

[Manishearth]

Yeah, it's not a big deal if the deadline is slipped, my hope was to get reviews as soon as they can be acquired, but if it takes time it takes time.

[xfq]

I have reviewed the spec and didn't found any:

• natural language text that would be read/searched by a user
• issues regarding character encoding
• markup elements/attributes
• local date/time/format

Some observation: the input profile name looks like an identifier instead of natural language text, so probably doesn't need language & direction metadata. The UI presented by the UA may contains natural language text, but the spec itself does not deal with that. There is a Normalization section, but it has nothing to do with Unicode normalization, so no issue there.

I filed a minor issue on input profile name, pending discussion by i18n WG: w3c/i18n-activity#949

I also filed a non-i18n issue: immersive-web/webxr#1110

[Manishearth]

Some observation: the input profile name looks like an identifier instead of natural language text, so probably doesn't need language & direction

It should never be exposed to the user, it's primarily consumed by this library though authors are also free to write bespoke code that checks which device you're using.

Your proposed change seems fine, though! There's no strong reason why it shouldn't be ASCII, but if we're restricting it to lowercase it seems okay for it to be ASCII-only anyway.

[aphillips]

This is not the place to discuss issues. I have created an issue to discuss this here topic.

[Manishearth]

@aphillips Can we consider this review to be "complete", or is there anything else that needs to be done? We have resolved immersive-web/webxr#1122