OverconstrainedError extends DOMException + algo fixes #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@henbos Regarding question in Thursday's meeting, |
|
It seems |
@saschanaz Can we return a base class interface in a WebIDL JS callback and have the following still work? navigator.mediaDevices.getUserMedia({video: {width: {min: 9999}}}, () => {}, e => {
console.log(e.constraint); // width
}); I've been working too much with dictionaries where this would be a problem. |
|
Yes, it should work. A working example is |
Co-authored-by: Dominique Hazael-Massieux <[email protected]>
Co-authored-by: Dominique Hazael-Massieux <[email protected]>
Co-authored-by: Dominique Hazael-Massieux <[email protected]>
Co-authored-by: Dominique Hazael-Massieux <[email protected]>
henbos
approved these changes
Nov 12, 2020
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Dec 8, 2020
This change removes the message and name members from the data for the OverconstrainedError interface, per the spec change at w3c/mediacapture-main#746, which redefined OverconstrainedError as as extending DOMException (which has message and name members that OverconstrainedError inherits).
ddbeck
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Dec 10, 2020
This change removes the message and name members from the data for the OverconstrainedError interface, per the spec change at w3c/mediacapture-main#746, which redefined OverconstrainedError as as extending DOMException (which has message and name members that OverconstrainedError inherits).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #568.
I made the
constraintargument always present and""in cases where the constraint name is either filtered out or undetermined. This matches Safari and Firefox at least (I wasn't able to provoke the absence of a constraint in Chrome).I also fixed some bugs in the algorithms around
failedConstraintin the process.Preview | Diff