Allow UA to clamp maxBufferSize to a value between 1 and the value provided by the web page #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovided by the web page
guidou
approved these changes
Jan 30, 2024
henbos
approved these changes
Feb 1, 2024
henbos
reviewed
Feb 1, 2024
| @@ -204,7 +212,7 @@ with |processor| as parameter. | |||
|
|
|||
| The <dfn>handleNewFrame</dfn> algorithm is given a |processor| as input. | |||
| It is defined by running the following steps: | |||
| 1. If |processor|.`[[maxBufferSize]]` has a value and |processor|.`[[queue]]` has |processor|.`[[maxBufferSize]]` elements, [=queue/dequeue=] an item from |processor|.`[[queue]]`. | |||
| 1. If |processor|.`[[queue]]` has |processor|.`[[maxBufferSize]]` elements, [=queue/dequeue=] an item from |processor|.`[[queue]]`. | |||
There was a problem hiding this comment.
You probably need to close the frame that you dequeued
There was a problem hiding this comment.
Good point, I'll fix it in this PR.
There was a problem hiding this comment.
If we close it here, we should also use "dequeue and close" on line 219.
There was a problem hiding this comment.
I'll file an issue about this.
For camera tracks, what we enqueue here is not a WebCodecs VideoFrame object but the necessary information to create one.
For VideoTrackGenerator tracks given to MediaStreamTrackProcessor, we could indeed directly enqueue VideoFrames but we would not expose this VideoFrame object but a clone.
|
Merging this PR given I filed #106 to handle the comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95
Preview | Diff