From 42221de70f854c13e67ef65bcbb6a589f840455a Mon Sep 17 00:00:00 2001
From: youennf <youennf@users.noreply.github.com>
Date: Mon, 22 Jan 2024 16:35:35 +0100
Subject: [PATCH] Update MediaPositionState WebIDL (#304)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Update MediaPositionState WebIDL

We add default values for position and playbackRate.
duration is now unrestricted to allow Infinity and we add a special check for NaN.
We do not make duration required so that MediaSession.setPositionState can still take an optional state argument.

Fixes https://github.com/w3c/mediasession/issues/303 and https://github.com/w3c/mediasession/issues/252.

Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
---
 index.bs | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/index.bs b/index.bs
index 01542c3..6407033 100644
--- a/index.bs
+++ b/index.bs
@@ -876,32 +876,30 @@ interface MediaSession {
 
   <ul>
     <li>
-      If the <var>state</var> is an empty dictionary then clear the <a>position
-      state</a>.
+      If <var>state</var> is an empty dictionary, clear the <a>position state</a>
+      and abort these steps.
     </li>
     <li>
-      If the <a dict-member for="MediaPositionState">duration</a> is not present
-      or its value is null, throw a <a exception>TypeError</a>.
+      If <var>state</var>'s <a dict-member for="MediaPositionState">duration</a> is not
+      present, throw a <a exception>TypeError</a>.
     </li>
     <li>
-      If the <a dict-member for="MediaPositionState">duration</a> is negative,
-      throw a <a exception>TypeError</a>.
+      If <var>state</var>'s {{MediaPositionState/duration}} is negative or
+      <code>NaN</code>, throw a <a exception>TypeError</a>.
     </li>
     <li>
-      If the <a dict-member for="MediaPositionState">position</a> is not present
-      or its value is null, set it to zero.
+      If <var>state</var>'s {{MediaPositionState/position}} is not present, set it to zero.
     </li>
     <li>
-      If the <a dict-member for="MediaPositionState">position</a> is negative or
+      If <var>state</var>'s <a dict-member for="MediaPositionState">position</a> is negative or
       greater than <a dict-member for="MediaPositionState">duration</a>, throw a
       <a exception>TypeError</a>.
     </li>
     <li>
-      If the <a dict-member for="MediaPositionState">playbackRate</a> is not
-      present or its value is null, set it to 1.0.
+      If <var>state</var>'s <a dict-member for="MediaPositionState">playbackRate</a> is not present, set it to 1.0.
     </li>
     <li>
-      If the <a dict-member for="MediaPositionState">playbackRate</a> is zero
+      If <var>state</var>'s {{MediaPositionState/playbackRate}} is zero,
       throw a <a exception>TypeError</a>.
     </li>
     <li>
@@ -1201,7 +1199,7 @@ dictionary</h2>
 <pre class="idl">
 
 dictionary MediaPositionState {
-  double duration;
+  unrestricted double duration;
   double playbackRate;
   double position;
 };