-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify cross-origin resources #173
Comments
To define this properly requires integration with Fetch. Basically once a response (including a redirect) is not same origin with respect to the request's origin, the request's origin is tainted. When that happens each response (including that response) needs to have the opt-in header, otherwise the eventual response is considered cross-origin. |
Thanks Anne for clarification. Let's say if multiple redirects happen, what origins are required in TAO? Also do we need TAO for each intermediate response? Let's say:
|
May I ask why resource_TAO_cross_origin_redirect_chain.html would pass? The last redirect doesn't have TAO. Can you clarify where the TAO needs to be present in the chain? |
If multiple redirects happen, the origin gets tainted and will be send out as "null". C should see "null" and reply accordingly. It shouldn't see B.com. And yes, each response in the chain needs to have TAO, unless there are some same-origin responses and it hasn't gone cross-origin yet. (The tests may well be incorrect.) |
Thanks Anne for the clarification and sorry for late response. I would like to give examples to see if I fully understand everything. Let's say we have a main frame in A.com, and some redirections happen within its child frame. How could the main frame get accesses to the child frame's timing information in each example? Example 1. Example 2. Example 3. Example 4. Example 5. |
Those look correct to me. |
@yoavweiss Why does this require Fetch integration? This seems to be a critical privacy issue. Can't this be monkey texted in? Pulling to L2 for consideration. |
Similarly to #152 (comment), we'd need to use Fetch Response objects for this and need Fetch Response objects to contain that information. Monkey patching this doesn't seem like the right way to go, outside the context of a larger rebase on top of Fetch. |
Happy to add the above example to the spec, as well as make sure the tests in web-platform-tests/wpt#13518 cover all those scenarios and make that an L2 blocker. The wider scope definition is something that will happen in #152 as part of L3. |
Closed by #196. It did not add explicit examples but the (handwavy) language there should make the above clearer. |
On the last call, we decided to postpone this alignment to L3, as it most probably requires implementation changes. |
Closing as #197 was merged |
When the spec refers cross-origin resources, are we talking about response or request origin?
For example, in resource_timing_cross_origin_redirect_chain.html, the resource loaded in frameContext was requested from a cross-origin site but then the respond is from the same-origin site. Should we treat the resource as cross-origin or same-origin? The test itself suggests the former. However, I didn't see any spec language defining this.
The text was updated successfully, but these errors were encountered: