Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text-decoration-fill and text-decoration-stroke #610

Closed
dirkschulze opened this issue Dec 8, 2018 · 4 comments
Closed

Remove text-decoration-fill and text-decoration-stroke #610

dirkschulze opened this issue Dec 8, 2018 · 4 comments

Comments

@dirkschulze
Copy link
Contributor

SVG2 defined text-decoration-fill and text-decoration-stroke. From the spec text (https://svgwg.org/svg2-draft/text.html#TextDecorationFillStroke) it is not cleat what the difference is to fill and stroke. There probably is none. In the meantime, the CSS WG decided that fill and stroke apply to all text in the Fill and Stroke module.

Should we remove the properties now?

@dirkschulze
Copy link
Contributor Author

@AmeliaBR @tabatkins @fantasai for further input.

@Tavmjong
Copy link
Contributor

These are not the same as 'fill' and 'stroke' which applies to the text itself. These apply to underlines, overlines, etc. (over-riding "fill" and "stroke" values). The CSS group at one time agreed to add these.

@AmeliaBR
Copy link
Contributor

it is not clear what the difference is to fill and stroke

The difference is the option to specify a different color (or paint effect) for the text decoration vs the text itself, equivalent to text-decoration-color.

That said, no one has implemented it yet, and there are issues with the way it is defined (we need a way to specify "use the main text fill/stroke" and also a way to specify "use the text-decoration-color value").
Placeholder issue for the fill & stroke spec: w3c/fxtf-drafts#254

So it probably makes sense to defer the new properties to the Fill & Stroke spec. But, we still need to define how text-decoration-color interacts with fill and stroke for SVG text: which one takes precedence?

@dirkschulze
Copy link
Contributor Author

@fantasai already opened the issue for text-decoration-color and fill and stroke. Closing this specific issue in favor of #591 which covers the *-fill and *-stroke properties as well and was discussed in todays call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants