Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't monkey patch #184

Closed
annevk opened this issue May 13, 2020 · 10 comments · Fixed by #355
Closed

Don't monkey patch #184

annevk opened this issue May 13, 2020 · 10 comments · Fixed by #355
Assignees
Labels
Status: Consensus to write We have TAG consensus about the principle but someone needs to write it (see "To Write" project)

Comments

@annevk
Copy link
Member

annevk commented May 13, 2020

We should incorporate some variant of https://annevankesteren.nl/2014/02/monkey-patch into https://w3ctag.github.io/design-principles/#spec-writing.

@dbaron
Copy link
Member

dbaron commented May 13, 2020

related to #99.

@hober hober self-assigned this May 18, 2020
@hober
Copy link
Contributor

hober commented May 18, 2020

Also related to #68.

@dbaron
Copy link
Member

dbaron commented Sep 23, 2020

@hober and I are discussing this in a breakout at our "Cork" virtual face-to-face. One point in our discussion is that we probably want the framing to both be "don't monkey patch" (although we probably want a less colloquial way to say this) and also "ask for and create extension points when needed".

@annevk
Copy link
Member Author

annevk commented Sep 23, 2020

Maybe not so much extension points as integration points. Arbitrary extension points often run into ordering issues.

@LeaVerou
Copy link
Member

I'm coming to this issue late and may be lacking some of the context, but these are my thoughts:

If extending an existing API in a way that is not explicitly permitted by its current extension/integration points yields better usability for web page authors, I think that is desirable, and the API just needs a new extension/integration point, rather than the extension itself being a bad practice that should be discouraged by a design principle (web page authors above spec writers etc etc). The ability to have a single source of truth for the entire API surface sounds like a tooling problem to me.

@annevk
Copy link
Member Author

annevk commented Jan 12, 2021

This is not so much about what is currently permitted, but how something is specified once it's decided that something is worth doing. I don't see it being in conflict with priority of constituencies at all.

@LeaVerou LeaVerou assigned kenchris and unassigned dbaron Sep 16, 2021
@LeaVerou LeaVerou added the Status: Consensus to write We have TAG consensus about the principle but someone needs to write it (see "To Write" project) label Sep 16, 2021
@LeaVerou
Copy link
Member

@kenchris and I discussed this during a breakout today and we agree this should be incorporated in https://w3ctag.github.io/design-principles/#spec-writing

@marcoscaceres would you like to take a stab at this? Ken said you have a lot of background on this topic.

@marcoscaceres
Copy link
Contributor

Sure, I can draft something up.

@torgo
Copy link
Member

torgo commented Jan 13, 2022

Hi @marcoscaceres we're just circling back on this. Did you get a chance to write something?

@marcoscaceres
Copy link
Contributor

Sorry for the delay: #355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Consensus to write We have TAG consensus about the principle but someone needs to write it (see "To Write" project)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants