-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie Store API #290
Comments
My main worry here is that |
@annevk "rather buggy" isn't very specific / actionable. I would prefer that we focus on concrete concerns. After reading whatwg/html#804 it seems to me that the problems discussed there fall into two buckets: parsing HTTP header values and character encoding. This API addresses the parsing issue by switching away from cookie line strings (HTTP header values) to dictionaries where cookie properties are already parsed. Granted, parsing concerns still leak through -- we currently disallow writing a cookie whose name is empty and value contains We plan to side-step the encoding issue by using USVString in the specification. The proposal currently states that cookie names and values are serialized using UTF-8. While @bsittler really cared about the latter, I don't see a lot of value in internationalizing an internal detail such as cookies, so I'd be fine with heavily restricting the supported cookie names/values (for example, to printable ASCII) if that's what it takes to get consensus here. I understand the list of problems above may be limited by my perception and experience, and I'm looking forward to learning about any additional concerns you have. I think it would be best to discuss each concern as a separate issue in https://github.com/WICG/cookie-store/issues because I find it hard to follow mega-issues such as whatwg/html#804. |
Even within the ASCII range it seems there's ample room for concern given the constraints put on HTTP headers (that these will eventually be serialized as). It's hard for me to get into specifics without doing all the necessary research to solve the issues myself. |
We've discussed this in our W3CTAG meeting. It would be great to see use cases written out in your explainer, so that we (and implementers) can see what problem you're setting out to solve here — who wants this and why. It would also be useful if you could describe in your explainer the alternative approaches you considered to solve that problem, and why you decided not to go with them. Also, have you talked to the IETF? They'll obviously have an interest in anything cookie-related; would be good to get them involved if you haven't already. |
Hi @pwnall and @inexorabletash! Just checking in on this, since it's on our TAG agenda for this week. Do you have comments or thoughts on the points above? |
@hadleybeeman Sorry for the delayed response. We added a use case section to the explainer. We've been talking to @mikewest who is an editor of the IETF RFC on cookies. |
Hey, @hadleybeeman! I agree that we should work through the ways in which One of the things on my list with RFC6265bis is to go through the places in which browsers' behavior diverges from RFC6265, and to adjust the specification accordingly. I haven't taken the time to do that work. I'm hopeful it'll get done this year, but it's not going to get done this quarter. |
Hello TAG!
I'm requesting a TAG review of:
Further details (optional):
You should also know that...
We are especially interested in feedback around developer ergonomics, such as API shape and naming.
We'd prefer the TAG provide feedback as (please select one):
The text was updated successfully, but these errors were encountered: