Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXR Augmented Reality Module #462

Closed
1 task done
mounirlamouri opened this issue Jan 14, 2020 · 3 comments
Closed
1 task done

WebXR Augmented Reality Module #462

mounirlamouri opened this issue Jan 14, 2020 · 3 comments
Assignees
Labels
Resolution: satisfied The TAG is satisfied with this design Venue: WebXR

Comments

@mounirlamouri
Copy link

mounirlamouri commented Jan 14, 2020

Hello TAG!

I'm requesting a TAG review of WebXR Augmented Reality Module.

The WebXR Augmented Reality Module extends the WebXR Device API to expose the ability to create a basic augmented reality (AR) session.

Further details:

  • I have reviewed the TAG's API Design Principles
  • Relevant time constraints or deadlines: Chrome will have an Intent to Ship soon for this API.
  • The group where the work on this specification is being done: Immersive Web WG
  • Major unresolved issues with or opposition to this specification: N/A
  • This work is being funded by: N/A

You should also know that...

  • This specification was split from the WebXR specification recently and has been designed as a module/extension.

We'd prefer the TAG provide feedback as (please delete all but the desired option):

🐛 open issues in our GitHub repo for each point of feedback

@atanassov
Copy link

@torgo and myself did a review pass at this proposal during our "Kronos" VF2F.

We found the answers to the privacy & security considerations section a bit small. This API claims to allow access to the camera image for use in compositing while ensuring the web site doesn't have access to it. This is a very important point to be made explicitly and normatively. The section about why the web site doesn't get access could use such clarity and the requirement ought to be normative (perhaps link to the XR Compositor section).

The terminology section defines types such as opaque, pass through and additive light but it is hard to tie these to real-world scenarios or devices. Which of these defines a phone or computer with camera, headsets etc.? In particular, what is an example of Opaque AR?

Section 2.5 of the spec can benefit greatly from a more complete motivational code example. Also, please clarify the use of the word Content - is this Site Content or Virtual Content?

@Manishearth
Copy link

Addressed comments in immersive-web/webxr-ar-module#63

@torgo torgo added Resolution: satisfied The TAG is satisfied with this design and removed Progress: in progress labels May 11, 2021
@torgo torgo added this to the 2021-05-10-F2F-Arakeen milestone May 11, 2021
@torgo
Copy link
Member

torgo commented May 11, 2021

Hi @Manishearth we are just coming back to tidy this up at our virtual F2F this week. Thanks for making note of that PR. This looks good to us and we're happy to close on this basis. Thanks for working with us and taking our comments into consideration. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: satisfied The TAG is satisfied with this design Venue: WebXR
Projects
None yet
Development

No branches or pull requests

7 participants