Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve25519 in Web Cryptography #466

Closed
1 task done
tQsW opened this issue Jan 23, 2020 · 11 comments
Closed
1 task done

Curve25519 in Web Cryptography #466

tQsW opened this issue Jan 23, 2020 · 11 comments
Assignees
Labels
Resolution: satisfied The TAG is satisfied with this design Review type: CG early review An early review of general direction from a Community Group Topic: security features

Comments

@tQsW
Copy link

tQsW commented Jan 23, 2020

Hello TAG!

I'm requesting a TAG review of adding support for Curve25519 in WebCrypto.

Today web developers are getting around the unavailability of Curve25519 in browser by either including an implementation of its operations in JavaScript or compiling a native one into WebAssembly. Aside from wasting bandwidth shipping algorithms that are already included in browsers that support TLS 1.3, this practice also has security implications, e.g. side-channel attacks as studied by Daniel Genkin et al.

Further details:

  • I have reviewed the TAG's API Design Principles
  • The group where the work on this design is being done (or is intended to be done in the future): WebCrypto WG
  • Existing major pieces of multi-stakeholder review or discussion of this design: N/A
  • Major unresolved issues with or opposition to this design: N/A
  • This work is being funded by: N/A

We'd prefer the TAG provide feedback as (please delete all but the desired option):

🐛 open issues in our GitHub repo for each point of feedback

@tQsW tQsW added Progress: untriaged Review type: CG early review An early review of general direction from a Community Group labels Jan 23, 2020
@dbaron
Copy link
Member

dbaron commented Jan 31, 2020

What's the plan for standardizing this? (I ask particularly given that the Web Cryptography Working Group is closed.

@hober hober added the Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review label Feb 5, 2020
@torgo torgo added Topic: security features and removed Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review Progress: untriaged labels Feb 5, 2020
@hober hober added the Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review label Feb 5, 2020
@torgo
Copy link
Member

torgo commented Feb 5, 2020

Pinging @wseltzer.

@wseltzer
Copy link

wseltzer commented Feb 8, 2020

If there's sufficient interest, we can start a WG or add it to the scope of an existing WG. Expressions of interest welcome to help us figure that out.

@plinss
Copy link
Member

plinss commented Feb 8, 2020

I think the main concern was ensuring that curve25519 is covered under the patent policy. My understanding is that it's sufficiently open-source/public domain that additional coverage under the patent policy isn't necessary. We'd like to get confirmation of that.

@armfazh
Copy link

armfazh commented Feb 9, 2020

Does the proposal targets both X25519 and Ed25519? I have interest on moving this forward.

@tQsW
Copy link
Author

tQsW commented Feb 10, 2020

Does the proposal target both X25519 and Ed25519?

Yes, this proposal targets both algorithms.

@sleevi
Copy link

sleevi commented Feb 14, 2020

If there's sufficient interest, we can start a WG or add it to the scope of an existing WG. Expressions of interest welcome to help us figure that out.

Right, the steps forward for the Web Crypto API had previously been discussed in w3c/webcrypto#181 where the suggestion had been to move into WICG , to also facilitate other spec maintenance

@dbaron
Copy link
Member

dbaron commented Mar 2, 2020

We (me, @plinss, @sangwhan, @ylafon) are looking at this again at our Wellington Face-to-Face. We don't have any concerns from a technical perspective, and while we realize there may be some discussion of which other algorithms may or may not be appropriate to add, we're probably not the right set of people to evaluate those.

At the same time, we'd strongly encourage that whatever does happen here have an appropriate standardization path.

@dbaron dbaron closed this as completed Mar 2, 2020
@dbaron dbaron added Resolution: satisfied The TAG is satisfied with this design and removed Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review labels Mar 2, 2020
@plinss
Copy link
Member

plinss commented Mar 2, 2020

Especially if the W3C winds up spinning up a WG just to do this work, we'd encourage that the WG also evaluates other curves such as 448

@paulmillr
Copy link

yeah 448 should be added to be future-proof. NSA already suggests only using curves that have at least 192 bits of security. which ain't 25519 (only ~126 bits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: satisfied The TAG is satisfied with this design Review type: CG early review An early review of general direction from a Community Group Topic: security features
Projects
None yet
Development

No branches or pull requests

10 participants