Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AbortSignal option to addEventListener #569

Closed
1 task done
josepharhar opened this issue Nov 12, 2020 · 2 comments
Closed
1 task done

Adding AbortSignal option to addEventListener #569

josepharhar opened this issue Nov 12, 2020 · 2 comments
Assignees
Labels
Progress: propose closing we think it should be closed but are waiting on some feedback or consensus Progress: review complete Resolution: satisfied The TAG is satisfied with this design Resolution: timed out The TAG has requesed additional information but has not received it Review type: later review Review type: small delta Topic: Architecture Architecture related topics Topic: DOM About or relating to the Document Object Model Topic: universal JavaScript Features that work on the web and non-web (e.g. node.js) Venue: WHATWG

Comments

@josepharhar
Copy link

HIQaH! QaH! TAG!

I'm requesting a TAG review of Adding AbortSignal option to addEventListener.

This feature adds a new AbortSignal option, named "signal", to the options parameter of addEventListener.
This new option can be used to remove the event listener with an AbortController by calling abort().
More context: whatwg/dom#911

  • Explainer¹ (minimally containing user needs and example code): none
  • Security and Privacy self-review²: none
  • GitHub repo (if you prefer feedback filed there): none
  • Primary contacts (and their relationship to the specification):
  • Organization/project driving the design: Google? NodeJS?
  • External status/issue trackers for this feature (publicly visible, e.g. Chrome Status): https://chromestatus.com/feature/5658622220566528

Further details:

We'd prefer the TAG provide feedback as (please delete all but the desired option):

💬 leave review feedback as a comment in this issue and @-notify @josepharhar

@josepharhar josepharhar added Progress: untriaged Review type: CG early review An early review of general direction from a Community Group labels Nov 12, 2020
@cynthia cynthia self-assigned this Nov 18, 2020
@cynthia cynthia added Progress: unreviewed Review type: later review Topic: Architecture Architecture related topics Topic: DOM About or relating to the Document Object Model Topic: universal JavaScript Features that work on the web and non-web (e.g. node.js) Venue: WHATWG and removed Progress: untriaged Review type: CG early review An early review of general direction from a Community Group labels Nov 18, 2020
@LeaVerou LeaVerou self-assigned this Jan 19, 2021
@josepharhar
Copy link
Author

This has already been added to the spec and has been implemented in firefox, chrome, and safari

@kenchris kenchris self-assigned this Jan 28, 2021
@kenchris
Copy link

@LeaVerou @cynthia and I looked at this in our TAG Virtual F2F and it looks very sensible and like a nice addition!

@cynthia cynthia added Progress: propose closing we think it should be closed but are waiting on some feedback or consensus Progress: review complete Resolution: satisfied The TAG is satisfied with this design Resolution: timed out The TAG has requesed additional information but has not received it Review type: small delta and removed Progress: unreviewed labels Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: propose closing we think it should be closed but are waiting on some feedback or consensus Progress: review complete Resolution: satisfied The TAG is satisfied with this design Resolution: timed out The TAG has requesed additional information but has not received it Review type: later review Review type: small delta Topic: Architecture Architecture related topics Topic: DOM About or relating to the Document Object Model Topic: universal JavaScript Features that work on the web and non-web (e.g. node.js) Venue: WHATWG
Projects
None yet
Development

No branches or pull requests

4 participants