Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXR Lighting Estimation #574

Closed
1 task done
alcooper91 opened this issue Nov 19, 2020 · 5 comments
Closed
1 task done

WebXR Lighting Estimation #574

alcooper91 opened this issue Nov 19, 2020 · 5 comments
Assignees
Labels

Comments

@alcooper91
Copy link

HIQaH! QaH! TAG!

I'm requesting a TAG review of the WebXR Lighting Estimation API

"Lighting Estimation" is implemented by AR platforms using a combination of sensors, cameras, algorithms, and machine learning. Lighting estimation provides input to rendering algorithms and shaders to ensure that the shading, shadows, and reflections of objects appear natural when presented in a diverse range of settings.

Further details:

  • I have reviewed the TAG's API Design Principles
  • Relevant time constraints or deadlines:
  • The group where the work on this specification is currently being done: W3C Immersive Web CG
  • The group where standardization of this work is intended to be done (if current group is a community group or other incubation venue): W3C Immersive Web
  • Major unresolved issues with or opposition to this specification: N/a
  • This work is being funded by: N/a

You should also know that...

N/a

We'd prefer the TAG provide feedback as (please delete all but the desired option):

🐛 open issues in our GitHub repo for each point of feedback

@torgo
Copy link
Member

torgo commented Jan 27, 2021

Hi @alcooper91! Thanks for this review request. We note that the response to privacy & security section is great. One thing we felt was missing was the mitigation information on fingerprinting- which is actually discussed in the privacy & security considerations section of the explainer. And it also seems like there are requirements in the explainer - e.g. quantization - which do not actually appear in the spec itself? From a functional point of view the proposal seems like a great addition to XR.

@torgo torgo modified the milestones: 2021-02-08-week, 2021-02-22-week Feb 8, 2021
@torgo torgo added the Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review label Feb 8, 2021
@alcooper91
Copy link
Author

Hi @torgo, I can certainly add a line to the Privacy section of the spec recommending quantization of the Spherical Harmonics and Primary Light Direction, I believe that was just a simple omission when trying to distill the key requirements from the explainer; but I'm not sure I understand what the first ask (about the fingerprinting mitigations) is, assuming it is separate from adding the quantization. Are you referring to the "How does this specification deal with sensitive information?" section of the security and privacy questionnaire?

Apologies for not responding sooner, it seemed that the only request was to simply add the additional quantization information.

@alcooper91
Copy link
Author

immersive-web/lighting-estimation#45 Adds the requested line about quantization to the spec.

@torgo
Copy link
Member

torgo commented Feb 22, 2021

Thanks for that! To clarify, the quantization was the same as the fingerprinting mitigation issue, yes. Thanks for responding to this feedback and being aware of these issues.

@torgo torgo added Progress: propose closing we think it should be closed but are waiting on some feedback or consensus Resolution: satisfied The TAG is satisfied with this design and removed Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review Progress: propose closing we think it should be closed but are waiting on some feedback or consensus labels Feb 22, 2021
@torgo
Copy link
Member

torgo commented Feb 24, 2021

We're happy to close this off now. Thanks for filing this and let us know if we can be of any more help.

@torgo torgo closed this as completed Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants