Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Spelling and Grammar Customization #913

Closed
schenney-chromium opened this issue Nov 3, 2023 · 2 comments
Closed

CSS Spelling and Grammar Customization #913

schenney-chromium opened this issue Nov 3, 2023 · 2 comments
Assignees
Labels
Mode: async Work to be done asynchronously Progress: review complete Resolution: satisfied The TAG is satisfied with this design

Comments

@schenney-chromium
Copy link

こんにちは TAG-さん!

I'm requesting a TAG review of CSS ::spelling and ::grammar pseudo classes, and the text-decoration-line: spelling/grammar-error property values.

CSS highlight pseudo-elements allow developers to style text that the UA has flagged as misspelled or grammatically incorrect, and line decorations exposing the UA’s default decorations for spelling and grammar errors. These features allow authors to choose more legible colors for the default spelling and grammar errors, highlight misspelled words with background colors or other decorations, and implement custom spell checking with native appearance.
For example, authors may customize the appearance of spelling/grammar mistakes when the UA’s default color for a mistake has inadequate contrast with the background color.

Further details:

  • [Yes] I have reviewed the TAG's Web Platform Design Principles
  • Relevant time constraints or deadlines: WebKit are currently implementing, chromium wants to ship it.
  • The group where the work on this specification is currently being done: CSS
  • Major unresolved issues with or opposition to this specification: None
  • This work is being funded by: Bloomberg

You should also know that...

These features have been enabled under experimental web platform features in chromium since August 2022, and I'm only requesting review now because there's an Intent to Ship and it was discovered that no TAG review was ever done.

We'd prefer the TAG provide feedback as (please delete all but the desired option):

💬 leave review feedback as a comment in this issue and @-notify [schenney-chromium]

@schenney-chromium
Copy link
Author

I see that #584 covered some aspects of this, the ::spelling and ::grammar pseudo classes, but not the text-decoration-line: spelling-error and grammar-error.

@torgo
Copy link
Member

torgo commented Nov 22, 2023

Hi @schenney-chromium - thanks for the opportunity to review this. We're happy to see this proceed. ✨✨

@torgo torgo closed this as completed Nov 22, 2023
@torgo torgo added Progress: review complete Resolution: satisfied The TAG is satisfied with this design and removed Progress: in progress labels Nov 22, 2023
@torgo torgo removed this from the 2023-11-20-week milestone Nov 22, 2023
@rhiaro rhiaro added Mode: async Work to be done asynchronously and removed Fast track? labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mode: async Work to be done asynchronously Progress: review complete Resolution: satisfied The TAG is satisfied with this design
Projects
None yet
Development

No branches or pull requests

4 participants