-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: extending store metrics #3042
Conversation
You can find the image built from this PR at
Built from 3c63460 |
1376b88
to
ef7dfce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing! 🔥 thanks so much!
I think there's a couple linting changes in libwaku. Not sure if they're intentional or not as they seem to be unrelated to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very insightful!
But what is different between the two "Waku Store Time (sec)" panels?
It is not obvious from the picture.
Also maybe the panels can get more height for better legend readability.
Thanks for the comment! ah yes, the thing is that I wasn't properly using the nph-0.6.0. They are intentional but aside from this PR ;P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yess.
Thank you It looks just fine now!
* adding query_metrics module * update fleet-dashboard with new store panels for better timing insight
Description
Brings new metrics to analyse the time spent by store.
In a store request, we have these time components:
We will have stats for (1 + 2) and (3)
From nwaku we don't have means to measure the database time, which should be manually measured by analysing
pg_stat_statemets
table with queries likeSELECT calls, total_exec_time, mean_exec_time, max_exec_time, left(query, 80) rows FROM pg_stat_statements ORDER BY total_exec_time DESC LIMIT 100;
.Changes
Issue