Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve binding for waku_sync #3102

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

darshankabariya
Copy link
Contributor

@darshankabariya darshankabariya commented Oct 8, 2024

Summary

Enhances error handling in Waku Sync Nim bindings by leveraging improved C++ bindings in Negentropy.

closes #3030

@darshankabariya darshankabariya marked this pull request as draft October 8, 2024 11:46
@darshankabariya darshankabariya marked this pull request as ready for review October 9, 2024 07:07
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you.

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3102

Built from 0ce56c0

@darshankabariya darshankabariya merged commit c3756e3 into master Oct 10, 2024
12 of 13 checks passed
@darshankabariya darshankabariya deleted the improve_raw_binding branch October 10, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Negentropy error handling improvements
3 participants