Responsive Razor Pages View Location #297

wangkanai · 2020-02-03T18:59:35Z

Reference #115

… file suffix.

sample/RazorApp/Pages/About/Index.temp.cshtml

wangkanai · 2020-02-04T15:37:30Z

This PR is taking a lot of my time more than expected. Might need to move on and come back to later.
If anybody could help out would be much appreciated.

wangkanai · 2020-02-05T00:08:15Z

@rynowak would you mind helping me out. Much appreciate if you can, because you are the original creator of PageViewLocationExpander.cs

I can ViewLocationExpander the _layout.cshtml, but not the page itself. Which i can't make out why it acting like this.

Mobile view

Tablet view

Desktop default

The ExpandPageHierarchy() result looks right. The page view location with the device file extension is correct. The layout work as expected. Just don't understand why the page device file extension is getting resolve to correct file.

The View Engine now needs to know about pages :(. This isn't ideal but the view engine needs to know what set of search paths to use. This was already hardcoded for controllers vs controllers + areas. It felt right to further hardcode instead of introduce a wierd abstraction that we only use. Additionally pages use a view location expander to implement an ascending directory search.

…en when it's surrounded by slashes.

rynowak · 2020-02-09T06:31:54Z

src/Hosting/PageLocationExpander.cs

+                    yield return location.Replace("{0}", "{0}." + device);
+                    // Fallback to the original default view
+                    yield return location;
+                }


Did you manage to figure this out? Anything I can help with still?

Please please help! I have my head spinning for a few days on this already. Much appreciated :-)

OK. I'll take a look tomorrow.

Thank you very much :-)

I think I see what's going on here.

We don't use view location expanders to locate the "view" for a Razor Page because we've already found it. The page itself is the "view" so we don't go through a lookup process. What you could do instead is use routing a select a different page.

The other problem that's solved by doing this selection in the routing layer is one you might not have noticed. Because you defined a page with the filename Index.mobile.cshtml that means that it will respond to the url /Index.mobile which is probably not what you wanted. Routing for pages is customizable to address all of this.

I've got a branch where I've coded this up. I'll send you a link, and I'm happy to answer whatever questions you have about it.

rynowak@692377f

rynowak@692377f

This code awesome, its open my perspective.
I see you a create ResponsiveAttribute, but see you use anywhere?

It's the convention for metadata types to use an attribute type. This would work for controllers as well. So if you had different action methods based on the device in use, that would "just work" with a controller as well.

Thank you very much for the explanation.

This also me wanna to revisit another issue #243 Responsive Option to include Web Api Controllers. By using conventions pattern might be a better way then to pass in options.

Look like Layout is not working yet with Areas. Another todo

Better to see in the browser tab

wangkanai · 2020-02-12T01:04:09Z

Not working for Razor Pages that are in Areas.

Next to do list of the day.

Reference to asp.net docs https://docs.microsoft.com/en-us/aspnet/core/mvc/controllers/areas?view=aspnetcore-3.1#areas-for-controllers-with-views

wangkanai · 2020-02-12T01:16:42Z

src/Hosting/ResponsivePageMatcherPolicy.cs

+            return false;
+        }
+
+        public Task ApplyAsync(HttpContext httpContext, CandidateSet candidates)


CandidateSet is another investing thing that need my further attention and study later.

https://github.com/dotnet/aspnetcore/blob/master/src/Http/Routing/src/Matching/CandidateSet.cs

wangkanai · 2020-02-12T01:48:32Z

sample/RazorApp/Areas/Admin/Pages/_ViewImports.cshtml

@@ -0,0 +1,3 @@
+@using RazorApp
+@namespace RazorApp.Pages


Wrong namespace and causing render issues

wangkanai · 2020-02-12T01:49:35Z

src/Hosting/PageLocationExpander.cs

+                {
+                    if (!location.Contains("/{1}/") 
+                        && !location.Contains("/Shared/") 
+                        && !location.Contains("/Areas/")


Maybe another place to determine the issue.

wangkanai · 2020-02-12T06:40:44Z

src/Hosting/PageMatcherPolicy.cs

+    internal class ResponsivePageMatcherPolicy : MatcherPolicy, IEndpointComparerPolicy, IEndpointSelectorPolicy
+    {
+        public ResponsivePageMatcherPolicy() 
+            => Comparer = EndpointMetadataComparer<IResponsiveMetadata>.Default;


This is another thing that i need to investigate more EndpointMetadataComparer

https://github.com/dotnet/aspnetcore/blob/master/src/Http/Routing/src/Matching/EndpointMetadataComparer.cs

Merged with #331 for OperatingSystem change to Platform

wangkanai · 2020-02-14T04:38:56Z

Investigate the following for convention for Areas

wangkanai · 2020-02-14T07:43:04Z

Got a working concept with responsive razor pages using areas coming in with PR #339.

mobile

tablet

Need to add unit tests and refactor later

Working concept with responsive razor pages using areas

wangkanai · 2020-02-14T07:52:36Z

@rynowak finally got it working for razor pages in areas too now.Thank you very much for your help to complete this feature of device responsive view for razor pages.

Much appreciated 🥇

wangkanai added 2 commits February 3, 2020 22:44

Responsive Razor Pages view location expander

0ad3ef4

Update to fix view locations

5a5b7ae

wangkanai added enhancement concept planned labels Feb 3, 2020

wangkanai added this to the 3.0 Alpha07 milestone Feb 3, 2020

Something about the page routing that make page not using alternative…

ea27f91

… file suffix.

wangkanai commented Feb 4, 2020

View reviewed changes

sample/RazorApp/Pages/About/Index.temp.cshtml Outdated Show resolved Hide resolved

wangkanai added the help wanted label Feb 4, 2020

wangkanai added 2 commits February 4, 2020 20:02

Update razor pages model

43aa903

Refactoring

6f666b6

wangkanai added 2 commits February 5, 2020 06:10

reformat

935f967

update license headers

eb4fc4f

wangkanai added 2 commits February 5, 2020 08:10

Let check for pages as first condition, we only handle the 'page' tok…

fc06f89

…en when it's surrounded by slashes.

Add explanation of why having 2 yield return

49fbbaf

wangkanai linked an issue Feb 5, 2020 that may be closed by this pull request

Responsive Razor Pages #115

Closed

Merge branch 'dev' into pages

1a9aacf

wangkanai modified the milestones: 3.0 Alpha07, 3.0 Alpha08 Feb 6, 2020

wangkanai and others added 4 commits February 6, 2020 23:02

Merge branch 'dev' into pages

051ce64

try swap view location expanders order

214fb64

Merge remote-tracking branch 'origin/pages' into pages

441ca0f

Merge branch 'dev' into pages

8e74e5c

rynowak reviewed Feb 9, 2020

View reviewed changes

Prototype using routing to select the page

692377f

wangkanai added 4 commits February 12, 2020 07:38

Add something to-do study comment later

9d1d107

Add Razor Pages in Areas

0e1baf6

Look like Layout is not working yet with Areas. Another todo

Add page title for easy working

1e1713b

Better to see in the browser tab

GitHub Action does not like my dotnet test

bb07a44

Add ViewImport to areas

a767994

Reference to asp.net docs https://docs.microsoft.com/en-us/aspnet/core/mvc/controllers/areas?view=aspnetcore-3.1#areas-for-controllers-with-views

wangkanai commented Feb 12, 2020

View reviewed changes

wangkanai mentioned this pull request Feb 12, 2020

Investigate CandidateSet #335

Closed

wangkanai added 3 commits February 12, 2020 08:19

file and folder name refactoring

314bed4

This is not work for areas

208b2da

update view for demo report

2cb1d1d

wangkanai commented Feb 12, 2020

View reviewed changes

wangkanai mentioned this pull request Feb 12, 2020

Responsive Razor Pages #115

Closed

wangkanai changed the title ~~Responsive Razor Pages view location expander~~ Responsive Razor Pages View Location Feb 12, 2020

wangkanai commented Feb 12, 2020

View reviewed changes

Some refactoring code style

6229dce

This was referenced Feb 12, 2020

Investigate EndpointMetadataComparer #336

Closed

Responsive Razor Pages in Areas not working #337

Closed

wangkanai linked an issue Feb 12, 2020 that may be closed by this pull request

Responsive Razor Pages in Areas not working #337

Closed

wangkanai and others added 2 commits February 12, 2020 13:48

Follow changes in main branch

884a5c5

Merged with #331 for OperatingSystem change to Platform

Merge branch 'dev' into pages

638f441

wangkanai added 2 commits February 14, 2020 14:44

Working concept with responsive razor pages using areas

4c31524

Need to add unit tests and refactor later

Merge pull request #339 from wangkanai/page/area

15ab683

Working concept with responsive razor pages using areas

wangkanai merged commit 26b625e into dev Feb 14, 2020

wangkanai deleted the pages branch February 14, 2020 07:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Responsive Razor Pages View Location #297

Responsive Razor Pages View Location #297

wangkanai commented Feb 3, 2020 •

edited

Loading

wangkanai commented Feb 4, 2020

wangkanai commented Feb 5, 2020 •

edited

Loading

rynowak Feb 9, 2020

wangkanai Feb 9, 2020

rynowak Feb 10, 2020

wangkanai Feb 10, 2020

rynowak Feb 11, 2020

rynowak Feb 11, 2020

wangkanai Feb 11, 2020

rynowak Feb 11, 2020

wangkanai Feb 11, 2020

wangkanai commented Feb 12, 2020

wangkanai Feb 12, 2020

wangkanai Feb 12, 2020

wangkanai Feb 12, 2020

wangkanai Feb 12, 2020

wangkanai commented Feb 14, 2020

wangkanai commented Feb 14, 2020 •

edited

Loading

wangkanai commented Feb 14, 2020

Responsive Razor Pages View Location #297

Responsive Razor Pages View Location #297

Conversation

wangkanai commented Feb 3, 2020 • edited Loading

wangkanai commented Feb 4, 2020

wangkanai commented Feb 5, 2020 • edited Loading

Mobile view

Tablet view

Desktop default

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wangkanai commented Feb 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wangkanai commented Feb 14, 2020

wangkanai commented Feb 14, 2020 • edited Loading

mobile

tablet

wangkanai commented Feb 14, 2020

wangkanai commented Feb 3, 2020 •

edited

Loading

wangkanai commented Feb 5, 2020 •

edited

Loading

wangkanai commented Feb 14, 2020 •

edited

Loading