Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 new problems when using FileIOUtils::quasi_memcmp(...) #391

Closed
shinespeciall opened this issue Jun 26, 2022 · 0 comments · Fixed by #397
Closed

2 new problems when using FileIOUtils::quasi_memcmp(...) #391

shinespeciall opened this issue Jun 26, 2022 · 0 comments · Fixed by #397
Labels
enhancement New feature or request low-priority The issue is not a major prioritization when considering new work. new-contributor-friendly the issue can be a good start if a new contributor want to join us

Comments

@shinespeciall
Copy link
Member

  1. we should compare through all the Tile data to find which tile has the least difference comparing to the new tile
  2. we should add logic to choose which tile to delete when find 2 similar tile and the editor is going to delete one of them. we need to reserve the tile with less feature, or change less time when loop through all the 64 nybbles. Using whatever method to find the tile with less feature to avoid leading noice pixels into some Tile16s or into the graphic.
@shinespeciall shinespeciall added enhancement New feature or request low-priority The issue is not a major prioritization when considering new work. new-contributor-friendly the issue can be a good start if a new contributor want to join us labels Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority The issue is not a major prioritization when considering new work. new-contributor-friendly the issue can be a good start if a new contributor want to join us
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant