Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete launched on readonly cells too #1332

Closed
lubianm opened this issue Feb 21, 2014 · 3 comments
Closed

Autocomplete launched on readonly cells too #1332

lubianm opened this issue Feb 21, 2014 · 3 comments
Labels

Comments

@lubianm
Copy link

lubianm commented Feb 21, 2014

On my handsontable I've added a couple of columns of type 'autocomplete', in 'strict' mode and with source loaded via Ajax. It seems that if the cell (autocomplete) is readonly, the 'source' function is executed (and I think that it shouldn't) anyway.
You can see an example of this behavior here http://jsfiddle.net/QkSF6/ just try to double-click Year1 on cell (readonly) with value '2002'; at the end of the table it will appear a paragraph showing the function execution.

@psmolenski psmolenski self-assigned this Feb 25, 2014
@mariotacke
Copy link

I agree with this issue. Also, IMO it should not show the dropdown arrow if an autocomplete or dropdown cell is readonly.

psmolenski added a commit that referenced this issue Mar 10, 2014
…rrow in cell of type `autocomplete`, if the cell is readOnly.
psmolenski referenced this issue Mar 20, 2014
Conflicts:
	test/jasmine/spec/editors/autocompleteEditorSpec.js
@lubianm
Copy link
Author

lubianm commented Mar 21, 2014

This issue seems solved on version 0.10.4, can you confirm ?

@psmolenski
Copy link
Contributor

Yes it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants