Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: uncaught connections errors #13

Open
HeIIow2 opened this issue Jun 19, 2023 · 2 comments
Open

[BUG]: uncaught connections errors #13

HeIIow2 opened this issue Jun 19, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@HeIIow2
Copy link
Contributor

HeIIow2 commented Jun 19, 2023

Description of the bug

Connection errors should be caught and processed, or at least there should be a silent paramater, that says, if an error should be thrown. There is an argument to be made, that this actually shouldn't be the case, but imo the silent parameter should exist.

I also reccomend using logging, then you could just print a warning. When I find the time I am gonna open a pr for this, if you haven't implemented it.

Also sorry if I come of rude, this library really is helpful, but it just crashed my 10 000 lines program. xD
Seriosly keep going.

<33

EDIT: IMO the silent attribute should just return an empty array if anything fails, because yk not segments.

Steps To Reproduce

  1. Use the programm
  2. Pull out your ethernet cable

Additional Information

No response

@HeIIow2 HeIIow2 added the bug Something isn't working label Jun 19, 2023
@wasi-master
Copy link
Owner

I agree that connection errors should be caught. I don’t know why I didn’t add this the first time lol. But yeah It should be raised as an error.

The silent attribute is a good idea too. And I have thought about using logging since the beginning but just didn’t get the chance to implement it

I may be able to add these in the next few days

@HeIIow2
Copy link
Contributor Author

HeIIow2 commented Jun 20, 2023

Great thank you! You'd do me a huge favor with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants