Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Cleanup benchmark CI scripts #444

Closed
Robbepop opened this issue Sep 16, 2022 · 1 comment
Closed

CI: Cleanup benchmark CI scripts #444

Robbepop opened this issue Sep 16, 2022 · 1 comment
Assignees
Labels
cleanup Cleans up some region of the codebase. enhancement New feature or request

Comments

@Robbepop
Copy link
Member

#422 added support for wasmi CI benchmarking.

While the whole thing seems to be working fine and outputs well formatted markdown code that is pretty readable the scripts that extract the benchmark information out of Criterion output are a bit unreadable.
Also those scripts depend on instable Criterion console output instead of depending on the more stable machine readable output documented here:
https://bheisler.github.io/criterion.rs/book/cargo_criterion/external_tools.html

We should make Criterion output JSON that our scripts could consume with tools such as jq (JSON query) in order to create the pretty printed markdown table.

This has 2 advantages:

  • Making current scripts more readable.
  • (More important) Make the CI less brittle and instable to changes in Criterion console output.
@Robbepop Robbepop added enhancement New feature or request cleanup Cleans up some region of the codebase. labels Sep 16, 2022
@Robbepop
Copy link
Member Author

Closed since #464 got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleans up some region of the codebase. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants