You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While the whole thing seems to be working fine and outputs well formatted markdown code that is pretty readable the scripts that extract the benchmark information out of Criterion output are a bit unreadable.
Also those scripts depend on instable Criterion console output instead of depending on the more stable machine readable output documented here: https://bheisler.github.io/criterion.rs/book/cargo_criterion/external_tools.html
We should make Criterion output JSON that our scripts could consume with tools such as jq (JSON query) in order to create the pretty printed markdown table.
This has 2 advantages:
Making current scripts more readable.
(More important) Make the CI less brittle and instable to changes in Criterion console output.
The text was updated successfully, but these errors were encountered:
#422 added support for
wasmi
CI benchmarking.While the whole thing seems to be working fine and outputs well formatted markdown code that is pretty readable the scripts that extract the benchmark information out of Criterion output are a bit unreadable.
Also those scripts depend on instable Criterion console output instead of depending on the more stable machine readable output documented here:
https://bheisler.github.io/criterion.rs/book/cargo_criterion/external_tools.html
We should make Criterion output JSON that our scripts could consume with tools such as
jq
(JSON query) in order to create the pretty printed markdown table.This has 2 advantages:
The text was updated successfully, but these errors were encountered: