Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Improve horizontal spacing of benchmark results table #488

Closed
Robbepop opened this issue Sep 30, 2022 · 0 comments · Fixed by #494
Closed

CI: Improve horizontal spacing of benchmark results table #488

Robbepop opened this issue Sep 30, 2022 · 0 comments · Fixed by #494
Assignees
@sergejparity

Comments

@Robbepop
Copy link
Member

With the enhancement of #487 that added Wasmtime based Wasm benchmark results to the table we now have a problem with horizontal spacing and can no longer see all result values without scrolling.

This should be improved.

  • We could decrease font size.
  • We could implement new lines for the long benchmark names to display execute/<newline>tiny_keccak.
  • We could also split the table into multiple tables, e.g. one table for native results and one for Wasm results.
    • However, I don't like this approach very much since having everything at one spot is actually a great feature.
  • etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergejparity sergejparity

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: Wrap benchmark name to reduce horizontal size of the report table wasmi-labs/wasmi
2 participants
@Robbepop @sergejparity