-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract_imports
and extract_memories
do push_memory
duplicated inModule::instantiate
#587
Comments
extract_imports
and extract_memories
do push_memory
duplicated ininstantiate
extract_imports
and extract_memories
do push_memory
duplicated inModule::instantiate
Sorry but I don't understand at all what exactly the problem is supposed to be here. |
Ok, I will add a test to show it. |
See #589 |
Hi @Robbepop Could you give me some feedback? |
Sorry, my initial answer was wrong, so I deleted it again, then I forgot to write another. I wrote a new answer as review comment to your PR. |
When building module,
memory
is collected by bothimports
andmemories
now.What I means
Memory::new
is called twice when there is only one import "env" "memory".The first one is called by me for pass it to linker, but the second one is called by
extract_memories
.But if we do not import memory,
Memory::new
never be called.The text was updated successfully, but these errors were encountered: