Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What kind of analysis to use in differential_modification.py for multiway analysis? #7

Open
endrebak opened this issue Nov 14, 2019 · 1 comment

Comments

@endrebak
Copy link
Contributor

By the way, allele_specific_modification.py does something very similar to differential_modification.py, only focussing on a simpler case of a 1 vs 1 comparison. The same improvements can probably be made in both scripts. The differential_modification script would eventually need better stats handling when comparing groups of samples, but for now I've just implemented this as a simple fisher exact test, which does suffice for within sample allele_specific_modification but is not optimal for across multiple samples differential_modification...

What kind of differential analysis did you have in mind for a multiway comparison?

@wdecoster
Copy link
Owner

Right now we're just handling groups of samples as they were only one sample and adding all methylated and non-methylated counts together, without i) increasing power by making use of multiple observations and while at the same time ii) ignoring any heterogeneity within the groups. For a 3 vs 3 comparison we should be comparing 3 ratios vs 3 ratios... but I'm not yet sure what's the most appropriate test for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants