-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Order the Card #360
base: main
Are you sure you want to change the base?
feat: Order the Card #360
Conversation
✅ Deploy Preview for wedancefareed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't delete this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't delete it just renamed it to .env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldn't rename it. you should copy it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as you see in this pull request, it shows that you deleted this file. revert this change.
</script> | ||
|
||
<style> | ||
.text { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use inline styles. Use Tailwind classes. See how other components are done. Do it similar.
@@ -1,5 +1,6 @@ | |||
<template> | |||
<div> | |||
<template v-if="!uid"><TOrderButton /></template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not an order button. Think more abstract.
It's a banner. It functionality should be similar to WTeaser
.
@@ -143,6 +138,11 @@ | |||
class="w-full mt-4" | |||
/> | |||
|
|||
<TCommunity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you rebase your code on top of main
branch.
This code change has nothing to do with your task. Make sure you don't break things.
@@ -302,6 +296,9 @@ import { | |||
import { useCities } from '~/use/cities' | |||
|
|||
export default { | |||
components: { | |||
TOrderButton, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nuxt is doing auto-import of components. No need to define components, they are already available.
Make a better title and description of this pull request. Include a preview link in description. |
How to test:
Demo: https://wedancefareed.netlify.app/fhareed
Closes #348