New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop pre-building Go std library #174

Open

bboreham opened this issue May 4, 2021 · 0 comments

Contributor

bboreham commented May 4, 2021

These lines:

build-tools/build/golang/Dockerfile

Lines 25 to 27 in dedde7f

    
           RUN go clean -i net && \ 
        
           	go install -tags netgo std && \ 
        
           	go install -race -tags netgo std

are not necessary since Go added a per-target build cache, and probably don't achieve anything
since we typically bind-mount another directory for the build cache when compilations are run: https://github.com/weaveworks/prom-aggregation-gateway/blob/c4415bbe1411d77eb4132f3df51c87cf7fcca840/Makefile#L60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment