This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Reinstate control over the git polling interval #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag --git-poll-interval used to control how often the daemon' sync loop would run a sync, which involved fetching any new commits, then applying the config (whether there were new commits or not) to the cluster. When git.Repo gained its own independent existence, the flag was left where it was, in the sync loop. That meant it controlled the syncs, but no longer the git polling, which was hard-wired. This commit makes it affect the git polling interval again, directly. The sync interval gets its own flag, with the same default value.
samb1729
approved these changes
Mar 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag --git-poll-interval used to control how often the daemon'
sync loop would run a sync, which involved fetching any new commits,
then applying the config (whether there were new commits or not) to
the cluster.
When git.Repo gained its own independent existence, the flag was left
where it was, in the sync loop. That meant it controlled the syncs,
but no longer the git polling, which was hard-wired.
This commit makes it affect the git polling interval again,
directly. The sync interval gets its own flag, with the same default
value.
Resolves #1029.