This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Include more information re "git repo not ready" #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a struct for not-ready-errors, so they can include the underlying problem. Since we now _expect_ there to be an underlying reason, create errors for "just haven't tried yet", and enforce the invariant of `not ready -> has error`.
Lots of tests use the git mirroring, and have to wait for it to report that it's ready before proceeding. We see this flake all the time, and it seemed odd that it couldn't complete a git clone on the local filesystem within five seconds. The helper function was trying every 100ms, five times, but reporting that it had tried for five seconds if it failed. Instead, try every 100ms, thirty times, and report accordingly.
squaremo
force-pushed
the
issue/1170-more-git-failure-info
branch
from
64a6b94 to
ab6fc85
Compare
aaron7
approved these changes
Jun 29, 2018
Fair question! Off the top of my head, it would be possible to set up various scenarios then make sure the git state machine arrived at the correct outcome. Slightly harder would be to check each transition, by stepping through a loop at a time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up git can be quite fiddly. One thing that would make it easier to troubleshoot is if fluxd did a better job of logging why it hadn't cloned the git repo yet.
This commit introduces a struct for not-ready-errors, so they can include the underlying problem. Since we now expect there to be an underlying reason, create errors for "just haven't tried yet", and enforce the invariant of
not ready -> has error.Fixes #1170.