Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Check if boolean policies equal true #1264

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

squaremo
Copy link
Member

@squaremo squaremo commented Aug 1, 2018

It should be possible to set the annotation, e.g.,

flux.weave.works/automated: 'false'

and expect automation to be off for that resource. However, since we
were checking only for the presence of the automation policy, and not
its value, any value was interpreted as on.

I've changed the name of the method used, so that it's a break from
the previous use (and to flush out where it was used).

Fixes #1256.

It should be possible to set the annotation, e.g.,

    flux.weave.works/automated: 'false'

and expect automation to be off for that resource. However, since we
were checking only for the presence of the automation policy, and not
its value, any value was interpreted as on.

I've changed the name of the method used, so that it's a break from
the previous use (and to flush out where it was used).
@squaremo squaremo requested a review from rndstr August 1, 2018 16:20
Copy link
Contributor

@rndstr rndstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👌

@squaremo squaremo merged commit 4bd4ed8 into master Aug 2, 2018
@squaremo squaremo deleted the issue/1256-policies-vs-annotations branch August 2, 2018 09:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants