Provide detailed pod status when listing services #1380

lelenanam · 2018-09-20T23:10:15Z

For deployments, daemonSet, statefulSet provide:

status of rollout
numbers of desired, updated, ready, available, outdated pods
slice of errors for controller

squaremo

I like this approach of just looking at the conditions on the controller -- thank you for taking my comments on the prior PR into account.

Three requested changes:

please either explain, or revise, the code that compiles errors from the conditions (I've expended on this in the comments)
the errors, or their replacement, need to be represented in the API response
daemonsets etc., should get the same treatment as deployments.

api/v6/api.go

@@ -34,6 +35,7 @@ type ControllerStatus struct {
 	Containers []Container
 	ReadOnly   ReadOnlyReason
 	Status     string
+	Pods       cluster.Pods


cluster/kubernetes/resourcekinds.go

@@ -120,27 +122,50 @@ func (dk *deploymentKind) getPodControllers(c *Cluster, namespace string) ([]pod
 	return podControllers, nil
 }

+func deploymentErrors(d *apiapps.Deployment) []string {
+	var errs []string
+	for _, cond := range d.Status.Conditions {


cluster/kubernetes/resourcekinds.go

 	}

 	return podController{
 		apiVersion:  "apps/v1",
 		kind:        "DaemonSet",
 		name:        daemonSet.ObjectMeta.Name,
 		status:      status,
+		pods:        pods,


lelenanam · 2018-09-24T18:16:31Z

StatefulSet Status is missing UpdatedReplicas field: kubernetes/kubernetes#52653

lelenanam · 2018-09-24T19:11:55Z

please either explain, or revise, the code that compiles errors from the conditions (I've expended on this in the comments)

added comment

the errors, or their replacement, need to be represented in the API response

moved Errors to RolloutStatus struct

daemonsets etc., should get the same treatment as deployments.

I wasn't able to find a way to get errors from deamonSet and statefulSet conditions.
I can include alldeamonSet and statefulSet conditions to errors list but not all of them might be about errors.

@squaremo

@squaremo PTAL

squaremo

The additional code looks good to me ✔️ Thanks Elena 🔆

Before you merge it, I would appreciate an explanation (as comments in the code) of why the interpretation for Deployments is correct, and why conditions aren't used elsewhere; and, documentation on how to use the RolloutStatus value in the API (including what to do if it's empty).

cluster/cluster.go

+	Available int32
+	// Outdated number of pods that are on a different pod spec.
+	Outdated int32
+	// Messages about unexpected rollout progress


cluster/cluster.go

@@ -21,6 +21,23 @@ type Cluster interface {
 	PublicSSHKey(regenerate bool) (ssh.PublicKey, error)
 }

+// RolloutStatus describes numbers of pods in a different states and


cluster/kubernetes/resourcekinds.go

-		updated, wanted := daemonSetStatus.UpdatedNumberScheduled, daemonSetStatus.DesiredNumberScheduled
-		if updated == wanted {
+		status = StatusUpdating
+		if rollout.Ready == rollout.Desired && rollout.Available == rollout.Desired && rollout.Outdated == 0 {


cluster/cluster.go

+// - in progress: Updated, Ready or Available numbers are not equal to Desired, or Outdated not equal to 0
+// - stuck: Messages contains info if deploynemt unavailable or exceeded its progress deadline
+// - complete: Updated, Ready and Available numbers are equal to Desired and Outdateds equal to 0
+// See https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#deployment-status


cluster/kubernetes/resourcekinds.go

+// Deployment may get stuck trying to deploy its newest ReplicaSet without ever completing.
+// One way to detect this condition is to specify a deadline parameter in Deployment spec:
+// .spec.progressDeadlineSeconds
+// See https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#failed-deployment


For deployments, daemonSet, statefulSet provide: - status of rollout - numbers of desired, updated, ready, available, outdated pods - slice of errors for controller (for now only for deployment) Fixes #1303

lelenanam requested review from squaremo and rndstr September 20, 2018 23:10

lelenanam mentioned this pull request Sep 20, 2018

Provide detailed pod status when listing services #1355

Closed

squaremo previously requested changes Sep 21, 2018

View reviewed changes

lelenanam force-pushed the 1303-listservices-controller-status branch from 5eb5a34 to c375d49 Compare September 24, 2018 19:02

lelenanam force-pushed the 1303-listservices-controller-status branch 2 times, most recently from 558a66a to 858efbb Compare September 24, 2018 20:36

rade requested a review from squaremo September 25, 2018 08:28

squaremo approved these changes Sep 25, 2018

View reviewed changes

rndstr approved these changes Sep 26, 2018

View reviewed changes

lelenanam force-pushed the 1303-listservices-controller-status branch 2 times, most recently from 14440db to c40b751 Compare September 26, 2018 21:15

squaremo reviewed Sep 26, 2018

View reviewed changes

Provide detailed pod status when listing services

df28361

For deployments, daemonSet, statefulSet provide: - status of rollout - numbers of desired, updated, ready, available, outdated pods - slice of errors for controller (for now only for deployment) Fixes #1303

lelenanam force-pushed the 1303-listservices-controller-status branch from c40b751 to df28361 Compare September 26, 2018 23:41

lelenanam merged commit 38d1507 into master Sep 26, 2018

lelenanam deleted the 1303-listservices-controller-status branch September 26, 2018 23:51

squaremo mentioned this pull request Oct 4, 2018

Show rollout progress in fluxctl release #1424

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide detailed pod status when listing services #1380

Provide detailed pod status when listing services #1380

lelenanam commented Sep 20, 2018

squaremo left a comment

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

lelenanam commented Sep 24, 2018

lelenanam commented Sep 24, 2018 •

edited

Loading

squaremo left a comment

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

Provide detailed pod status when listing services #1380

Provide detailed pod status when listing services #1380

Conversation

lelenanam commented Sep 20, 2018

squaremo left a comment

Choose a reason for hiding this comment

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

lelenanam commented Sep 24, 2018

lelenanam commented Sep 24, 2018 • edited Loading

squaremo left a comment

Choose a reason for hiding this comment

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

lelenanam commented Sep 24, 2018 •

edited

Loading