Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Use weaveworks/flux-get-started repo in docs #1527

Merged
merged 9 commits into from
Nov 19, 2018
Merged

Use weaveworks/flux-get-started repo in docs #1527

merged 9 commits into from
Nov 19, 2018

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Nov 17, 2018 •
edited
Loading

  • replace flux-example and flux-helm-test repos with flux-get-started
  • rename FluxHelmRelease with HelmRelease
  • remove helm-op git flags
  • use the same git URL format everywhere
  • update FAQ by removing resolved issues

Fix #1360 #1528

@stefanprodan
Update chart readme
b31a3b3 
- remove helm-op git flags
- fix typos
- set example repo to weaveworks/flux-get-started
- use the same git URL format everywhere
@stefanprodan
Fix links in Helm integration doc
6eac2db
@stefanprodan
Update annotations example to match flux-get-started
0d3ce71
@stefanprodan
Update Helm get started docs with flux-get-started repo
50785d8 
- remove GKE node constraint since it doesn't apply anymore
@stefanprodan
Update Flux get started docs with flux-get-started repo
8c540b4 
- remove GKE node constraint since it doesn't apply anymore
@stefanprodan stefanprodan added the docs Issue or PR relates to documentation label Nov 17, 2018
@stefanprodan stefanprodan mentioned this pull request Nov 17, 2018
Closed
@stefanprodan stefanprodan mentioned this pull request Nov 18, 2018
Closed
squaremo
squaremo reviewed Nov 19, 2018
View reviewed changes
chart/flux/README.md Outdated Show resolved Hide resolved
chart/flux/README.md
@@ -78,7 +75,7 @@ weaveworks/flux

```sh
$ helm install --name flux \
--set git.url=ssh://[email protected]/weaveworks/flux-helm-test \
--set [email protected]:weaveworks/flux-get-started \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it clear that this is a non-working example? Using the weaveworks/ repo will fail, since it won't be writable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a note at the top

chart/flux/README.md Outdated Show resolved Hide resolved
chart/flux/README.md Show resolved Hide resolved
site/get-started.md Outdated Show resolved Hide resolved
@stefanprodan
Add the GitHub username replacement after forking
82569d8 
- fix typos
- add back the git timeout and poll interval
squaremo
squaremo reviewed Nov 19, 2018
View reviewed changes
chart/flux/README.md Outdated Show resolved Hide resolved
squaremo
squaremo reviewed Nov 19, 2018
View reviewed changes
chart/flux/README.md Outdated Show resolved Hide resolved
squaremo
squaremo reviewed Nov 19, 2018
View reviewed changes
site/faq.md Outdated Show resolved Hide resolved
squaremo
squaremo approved these changes Nov 19, 2018
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after those suggestions I accidentally made as "Single Comment"s are dealt with :-)

@stefanprodan stefanprodan merged commit 52a67d2 into master Nov 19, 2018
@stefanprodan stefanprodan deleted the docsup branch November 19, 2018 18:13
This was referenced Nov 22, 2018
Merged
Closed
@hiddeco hiddeco mentioned this pull request Apr 4, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@squaremo squaremo squaremo approved these changes

Assignees
No one assigned
Labels
docs Issue or PR relates to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider new Helm example
2 participants
@stefanprodan @squaremo