This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
create minimal nsswitch.conf file in Docker image #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result, /etc/hosts will be prioritized over DNS queries This resolves the conflict between: * fluxd using netgo for static compilation. netgo reads nsswitch.conf to mimic glibc, defaulting to prioritize DNS queries over /etc/hosts if nsswitch.conf is missing: golang/go#22846 * Alpine not including a nsswitch.conf file. Since Alpine doesn't use glibc (it uses musl), maintainers argue that the need of nsswitch.conf is a Go bug: gliderlabs/docker-alpine#367 (comment)
errordeveloper
approved these changes
Jan 4, 2019
| # * Alpine not including a nsswitch.conf file. Since Alpine doesn't use glibc | ||
| # (it uses musl), maintainers argue that the need of nsswitch.conf is a Go bug: | ||
| # https://github.com/gliderlabs/docker-alpine/issues/367#issuecomment-354316460 | ||
| RUN [ ! -e /etc/nsswitch.conf ] && echo 'hosts: files dns' > /etc/nsswitch.conf |
There was a problem hiding this comment.
I would write out the entire file as it is, and make this a COPY ./nsswitch.conf /etc/nsswitch.conf. Given the context, I doubt it would eventually appear in the Alpine image.
There was a problem hiding this comment.
That's a fair point; on the other hand it doesn't hurt to be careful.
There was a problem hiding this comment.
Imho the current one-liner is great; I doubt we will ever make changes to the nsswitch.conf content so there is no reason to maintain a separate file to ease modifications.
hiddeco
approved these changes
Jan 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result, /etc/hosts will be prioritized over DNS queries
This resolves the conflict between:
defaulting to prioritize DNS queries over /etc/hosts if nsswitch.conf is missing:
net: Go DNS resolver does not read /etc/hosts golang/go#22846
(it uses musl), maintainers argue that the need of nsswitch.conf is a Go bug:
Alpine linux doesn't have nsswitch configuration file gliderlabs/docker-alpine#367 (comment)
Fixes #1627